Rename toWarnDev -> toErrorDev, toLowPriorityWarnDev -> toWarnDev #17605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a0b8017:
|
gaearon
force-pushed
the
rename-matchers
branch
from
35313aa
to
5c407ab
Compare
gaearon
force-pushed
the
rename-matchers
branch
from
5c407ab
to
a0b8017
Compare
necolas
approved these changes
Dec 16, 2019
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
…7605) * Rename toWarnDev -> toErrorDev in tests * Rename toWarnDev matcher implementation to toErrorDev * Rename toLowPriorityWarnDev -> toWarnDev in tests and implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #17599.
Part of #16753.
This renames the matchers to match the console method names, now that we use console directly:
toWarnDev->toErrorDev(because it capturesconsole.errorcalls)toLowPriorityWarnDev->toWarnDev(because it capturesconsole.warncalls)I initially considered more explicit names like
toConsoleErrorDevbut it's annoying when it's used so much. Arguably there could be some confusion betweentoThrowandtoErrorDev, but the*Devsuffix in my opinion is sufficient to remember which one does what.