Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename toWarnDev -> toErrorDev, toLowPriorityWarnDev -> toWarnDev #17605

Merged
merged 3 commits into from Dec 16, 2019

Conversation

@gaearon
Copy link
Member

gaearon commented Dec 14, 2019

Continues #17599.
Part of #16753.

This renames the matchers to match the console method names, now that we use console directly:

  • toWarnDev -> toErrorDev (because it captures console.error calls)
  • toLowPriorityWarnDev -> toWarnDev (because it captures console.warn calls)

I initially considered more explicit names like toConsoleErrorDev but it's annoying when it's used so much. Arguably there could be some confusion between toThrow and toErrorDev, but the *Dev suffix in my opinion is sufficient to remember which one does what.

@gaearon gaearon requested a review from bvaughn Dec 14, 2019
@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Dec 14, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a0b8017:

Sandbox Source
zealous-wescoff-ht8dq Configuration
@sizebot

This comment has been minimized.

Copy link

sizebot commented Dec 14, 2019

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against a0b8017

@sizebot

This comment has been minimized.

Copy link

sizebot commented Dec 14, 2019

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against a0b8017

@gaearon gaearon force-pushed the gaearon:rename-matchers branch from 35313aa to 5c407ab Dec 14, 2019
@gaearon gaearon force-pushed the gaearon:rename-matchers branch from 5c407ab to a0b8017 Dec 14, 2019
@gaearon gaearon merged commit 0b5a26a into facebook:master Dec 16, 2019
21 checks passed
21 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
@gaearon gaearon deleted the gaearon:rename-matchers branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.