Fix test_build_devtools CI job to run test-build-devtools #17631

gaearon · 2019-12-16T23:09:09Z

We're testing the wrong thing in this job. Probably bad copy paste.
As a result, regressions like #17599 creep in.

First commit is a small fix that fixes running it locally after a package got renamed. (The command crashed for me locally otherwise, which made verifying the fix annoying.)

The second commit makes the right command run on CI. It fails, as expected.

The third commit fixes #17630.

This fixes a problem that occurs after renaming a package.

codesandbox-ci · 2019-12-16T23:10:43Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6e60342:

Sandbox	Source
modest-shirley-we11g	Configuration

codesandbox-ci · 2019-12-16T23:12:08Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9cea553:

Sandbox	Source
nameless-wind-ydqrj	Configuration

sizebot · 2019-12-16T23:16:32Z

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 9cea553

sizebot · 2019-12-16T23:18:31Z

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 386796d

This should fix the createRoot error.

bvaughn

Thank you!

bvaughn · 2019-12-16T23:32:06Z

.circleci/config.yml

@@ -278,7 +278,7 @@ jobs:
      - run:
          environment:
            RELEASE_CHANNEL: stable
-          command: yarn test-build --maxWorkers=2
+          command: yarn test-build-devtools --maxWorkers=2


bvaughn · 2019-12-16T23:32:46Z

scripts/jest/preprocessor.js

-          ? [pathToBabelPluginReplaceConsoleCalls]
-          : [];
+      const sourceOnlyPlugins = [];
+      if (process.env.NODE_ENV === 'development' && !isInDevToolsPackages) {


bvaughn · 2019-12-16T23:48:54Z

packages/react-devtools-shared/src/__tests__/inspectedElementContext-test.js

@@ -542,7 +543,7 @@ describe('InspectedElementContext', () => {
          // eslint-disable-next-line no-undef
          big_int={BigInt(123)}
          data_view={dataView}
-          date={new Date(123)}
+          date={new Date(exampleDateISO)}


gaearon · 2019-12-16T23:48:56Z

OK this one should actually fix it.

bvaughn · 2019-12-16T23:51:34Z

Hm...looks like this has been broken for a while (since the stable/experimental stuff was split out) and we just haven't noticed?

I think to build a version of React that DevTools can consume now we would need to run:

RELEASE_CHANNEL=experimental yarn build -- react/index,react-dom,react-is,react-debug-tools,scheduler,react-test-renderer --type=NODE

(Or just download the latest experimental CI artifact, which might be better.)

gaearon · 2019-12-16T23:52:26Z

Do you mean we need to change the CI command to do this too?

bvaughn · 2019-12-16T23:53:50Z

Since DevTools and its tests depend on the createRoot API, which is now only exported for experimental builds, yeah. We'd need to make sure we were feeding it an experimental build.

I think to do this, we'd need to make test_build_devtools depend on the build_experimental target rather than the current build target.

gaearon · 2019-12-16T23:54:04Z

On CI, we already have test_build_devtools specify build job as a dependency so I don't think there's further action necessary. For local testing it would be nice to do this — or at least to have something warning you when you forget to.

gaearon · 2019-12-16T23:54:27Z

Since DevTools and its tests depend on the createRoot API, which is now only exported for experimental builds, yeah. We'd need to make sure we were feeding it an experimental build.

This is what I did in 2049b94.

gaearon · 2019-12-16T23:55:12Z

Ohh I see what you're saying. That this wouldn't be sufficient.

bvaughn · 2019-12-16T23:55:55Z

Yeah, I think to get tests passing we need to use the experimental build command. Then I'll I'll follow up on the rest of this (the actual build/release process) as part of #17629

bvaughn · 2019-12-17T00:03:18Z

Thanks Dan! <3

gaearon · 2019-12-17T00:04:32Z

My "pleasure"!

facebook-github-bot added the CLA Signed label Dec 16, 2019

gaearon added 2 commits December 16, 2019 23:10

Skip abandoned project folders in Jest config

209ced0

This fixes a problem that occurs after renaming a package.

Fix test_build_devtools to run test-build-devtools

549f1be

gaearon force-pushed the build-dt branch from 6e60342 to 549f1be Compare December 16, 2019 23:10

Exclude console.error plugin for DevTools packages

3233d78

gaearon requested a review from bvaughn December 16, 2019 23:21

Use correct release channel for DevTools tests

2049b94

This should fix the createRoot error.

bvaughn approved these changes Dec 16, 2019

View reviewed changes

Fix TZ dependent test

386796d

bvaughn reviewed Dec 16, 2019

View reviewed changes

Change DT job dependencies

9cea553

bvaughn merged commit 36a6e29 into facebook:master Dec 17, 2019

gaearon deleted the build-dt branch December 17, 2019 00:04

gaearon mentioned this pull request Dec 17, 2019

Move DevTools CI job to experimental workflow #17640

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix test_build_devtools CI job to run test-build-devtools #17631

Fix test_build_devtools CI job to run test-build-devtools #17631

gaearon commented Dec 16, 2019 •

edited

codesandbox-ci bot commented Dec 16, 2019

codesandbox-ci bot commented Dec 16, 2019 •

edited

sizebot commented Dec 16, 2019 •

edited

sizebot commented Dec 16, 2019 •

edited

bvaughn left a comment

bvaughn Dec 16, 2019

bvaughn Dec 16, 2019

bvaughn Dec 16, 2019

gaearon commented Dec 16, 2019

bvaughn commented Dec 16, 2019 •

edited

gaearon commented Dec 16, 2019

bvaughn commented Dec 16, 2019

gaearon commented Dec 16, 2019

gaearon commented Dec 16, 2019

gaearon commented Dec 16, 2019

bvaughn commented Dec 16, 2019

bvaughn commented Dec 17, 2019

gaearon commented Dec 17, 2019

Fix test_build_devtools CI job to run test-build-devtools #17631

Fix test_build_devtools CI job to run test-build-devtools #17631

Conversation

gaearon commented Dec 16, 2019 • edited

codesandbox-ci bot commented Dec 16, 2019

codesandbox-ci bot commented Dec 16, 2019 • edited

sizebot commented Dec 16, 2019 • edited

Size changes (experimental)

sizebot commented Dec 16, 2019 • edited

Size changes (stable)

bvaughn left a comment

Choose a reason for hiding this comment

bvaughn Dec 16, 2019

Choose a reason for hiding this comment

bvaughn Dec 16, 2019

Choose a reason for hiding this comment

bvaughn Dec 16, 2019

Choose a reason for hiding this comment

gaearon commented Dec 16, 2019

bvaughn commented Dec 16, 2019 • edited

gaearon commented Dec 16, 2019

bvaughn commented Dec 16, 2019

gaearon commented Dec 16, 2019

gaearon commented Dec 16, 2019

gaearon commented Dec 16, 2019

bvaughn commented Dec 16, 2019

bvaughn commented Dec 17, 2019

gaearon commented Dec 17, 2019

gaearon commented Dec 16, 2019 •

edited

codesandbox-ci bot commented Dec 16, 2019 •

edited

sizebot commented Dec 16, 2019 •

edited

sizebot commented Dec 16, 2019 •

edited

bvaughn commented Dec 16, 2019 •

edited