Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build FB RN targets only in experimental mode #17641

Merged
merged 1 commit into from Dec 17, 2019
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Dec 17, 2019

Similar to what we already do for WWW.

This will break RN sync script. I need to follow up there to do both a stable and an experimental build (and use the experimental build internally). The perf concern should be mitigated by the fact that we already can just download artifacts.

@sizebot
Copy link

sizebot commented Dec 17, 2019

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against fa0c0be

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fa0c0be:

Sandbox Source
snowy-lake-ydl7d Configuration

@gaearon gaearon requested a review from bvaughn December 17, 2019 19:27
@sizebot
Copy link

sizebot commented Dec 17, 2019

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against fa0c0be

@gaearon gaearon merged commit 4b0cdf2 into facebook:master Dec 17, 2019
@gaearon gaearon deleted the rn-fb branch December 17, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants