Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CircleCI DevTools build artifact tar internal structure #17758

Merged

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 2, 2020

Oops. Previously the tar.gz file had nested folders instead of it, which made it awkward to work with.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 328b90b:

Sandbox Source
frosty-frog-okj87 Configuration

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly did it fix? Or is this just to make it clearer?

@sizebot
Copy link

sizebot commented Jan 2, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 328b90b

@sizebot
Copy link

sizebot commented Jan 2, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 328b90b

@threepointone
Copy link
Contributor

I'm just unsure how this command makes a different internal structure in the compressed file. Feel free to ignore if it's not important.

@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 2, 2020

Before, unzipping the .tar.gz file would unpack to ./build/devtools/<stuff>. Now it will unpack to ./<stuff>.

@bvaughn bvaughn merged commit b05cd61 into facebook:master Jan 2, 2020
@bvaughn bvaughn deleted the devtools-fix-ci-build-artifacts-tar branch January 2, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants