Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node v13 for development #17837

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@jasonwilliams
Copy link
Contributor

jasonwilliams commented Jan 14, 2020

Summary

I can't build with Node v13 installed.
This should fix that

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Jan 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ae7d927:

Sandbox Source
sparkling-snow-899i2 Configuration
@sizebot

This comment has been minimized.

Copy link

sizebot commented Jan 14, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against ae7d927

@sizebot

This comment has been minimized.

Copy link

sizebot commented Jan 14, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against ae7d927

@gaearon gaearon merged commit 643dcb5 into facebook:master Jan 14, 2020
22 checks passed
22 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Jan 14, 2020

Thanks Jason!

trueadm added a commit to trueadm/react that referenced this pull request Jan 17, 2020
trueadm added a commit to trueadm/react that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.