Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to flow-bin@0.89 #17842

Merged
merged 1 commit into from Jan 22, 2020
Merged

Update to flow-bin@0.89 #17842

merged 1 commit into from Jan 22, 2020

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Jan 14, 2020 •
edited

Summary

Incremental Flow update.
Versions above 0.89 introduce new types of error.

Test Plan

yarn flow dom

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 14, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 14, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b63169:

Sandbox Source
boring-tree-xdfun Configuration

@sizebot
Copy link

sizebot commented Jan 14, 2020 •
edited

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 4b63169

@sizebot
Copy link

sizebot commented Jan 14, 2020 •
edited

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 4b63169

@bvaughn
Copy link
Contributor

bvaughn commented Jan 15, 2020 •
edited

The DevTools alphaSortEntries Flow error is correctly pointing out that I'm passing it the return value of Object.keys() rather than Object.entries(). It just happens to work because of string index hashing.

I'll shoot you a PR in a moment that fixes this.

@bvaughn bvaughn mentioned this pull request Jan 15, 2020
Merged
@necolas necolas force-pushed the update-flow branch 2 times, most recently from 8398861 to 8703333 Compare January 21, 2020 22:08
@necolas necolas requested a review from trueadm January 22, 2020 17:29
trueadm
trueadm approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

@necolas necolas merged commit 6c00c5b into facebook:master Jan 22, 2020
@necolas necolas deleted the update-flow branch January 22, 2020 18:40
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
@necolas
Update to flow-bin@0.89 (#17842)
a427f93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

@bvaughn bvaughn Awaiting requested review from bvaughn

@gaearon gaearon Awaiting requested review from gaearon

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@necolas @sizebot @bvaughn @trueadm @facebook-github-bot