-
Notifications
You must be signed in to change notification settings - Fork 48.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unstable_renderSubtreeIntoContainer and unstable_createPortal feature flags #17880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
requested review from
threepointone,
bvaughn,
sebmarkbage,
necolas,
gaearon,
lunaruan and
acdlite
January 21, 2020 13:47
facebook-github-bot
added
CLA Signed
React Core Team
Opened by a member of the React Core Team
labels
Jan 21, 2020
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 46cee59:
|
Details of bundled changes.Comparing: 0c04aca...46cee59 react-dom
Size changes (experimental) |
Details of bundled changes.Comparing: 0c04aca...46cee59 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
bvaughn
approved these changes
Jan 21, 2020
trueadm
force-pushed
the
react-dom-unstable-flags
branch
from
January 21, 2020 17:14
d0de0a5
to
da119d5
Compare
necolas
approved these changes
Jan 21, 2020
trueadm
force-pushed
the
react-dom-unstable-flags
branch
2 times, most recently
from
January 21, 2020 20:44
0a96835
to
0447b41
Compare
…ture flags Add flags to other files address feedback Fix The ReactDOM.unstable_createPortal() Trigger build Make message same as before
trueadm
force-pushed
the
react-dom-unstable-flags
branch
from
January 21, 2020 20:49
0447b41
to
e327e4a
Compare
Merged
This was referenced Mar 6, 2020
This was referenced Sep 25, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 25, 2024
This was referenced Oct 26, 2024
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two feature flags:
disableUnstableRenderSubtreeIntoContainer
forReactDOM.unstable_renderSubtreeIntoContainer
disableUnstableCreatePortal
forReactDOM.unstable_createPortal
These disable the relevant unstable/deprecated ReactDOM APIs. Additionally
ReactDOM.unstable_renderSubtreeIntoContainer
has a deprecation warning message as follows:The ReactDOM.unstable_renderSubtreeIntoContainer() is deprecated and will be removed in a future major release. Consider using React Portals instead.
I also changed the flowconfig to have the follow config, otherwise CI fails on this PR:
server.max_workers=4