Remove call to finishHooks when doing a static render.

[ijxsid2]

Summary

Fixes #16416 . If you had a renderToStaticMarkup or renderToString inside the hook, it would cause all the hooks to finish and set workInProgressHook to null. In this PR, I am trying to call the finishHooks only when we're not doing a static markup.

Test Plan

Its my first issue so I might have missed something. I ran yarn test, yarn linc and yarn flow, they are all passing. Also, I am not sure how to add a test for this.

[facebook-github-bot]

Hi ijxsid! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7ee2982:

Sandbox	Source
elegant-merkle-3pkk1	Configuration
Cannot set property 'memoizedState' of null	Issue #16416

[sizebot]

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 7ee2982

[sizebot]

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 7ee2982

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[gaearon]

I don't understand this fix. What makes makeStaticMarkup special that we don't need to call the function? Are you sure you're fixing the root cause and not the symptom? This also doesn't have any new tests — which means we can't verify what you tried to fix.