Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-closure-compiler #17902

Merged
merged 1 commit into from Jan 31, 2020
Merged

Conversation

@necolas
Copy link
Contributor

necolas commented Jan 23, 2020

Summary

Updates the google-closure-compiler dependency

Test Plan

CI

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Jan 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 813493f:

Sandbox Source
headless-dust-gl0wl Configuration
@sizebot

This comment has been minimized.

Copy link

sizebot commented Jan 23, 2020

Details of bundled changes.

Comparing: 6ae2c33...813493f

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js -0.1% -0.0% 123.81 KB 123.69 KB 38.8 KB 38.79 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 138.97 KB 138.97 KB 36.81 KB 36.81 KB UMD_DEV
react-dom-server.browser.production.min.js -0.0% 0.0% 20.47 KB 20.46 KB 7.5 KB 7.5 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 54.86 KB 54.86 KB 15.43 KB 15.43 KB UMD_DEV
ReactDOMServer-prod.js -0.0% -0.1% 49 KB 48.99 KB 11.19 KB 11.18 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 710 B 712 B UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 53.13 KB 53.13 KB 15.11 KB 15.11 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.05 KB 1.05 KB 641 B 643 B NODE_PROD
react-dom.development.js 0.0% 0.0% 961.05 KB 961.05 KB 215.76 KB 215.77 KB UMD_DEV
react-dom.production.min.js -0.0% 0.0% 119.85 KB 119.81 KB 38.42 KB 38.43 KB UMD_PROD
react-dom.profiling.min.js -0.1% -0.1% 123.58 KB 123.45 KB 39.61 KB 39.58 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 955.11 KB 955.11 KB 214.09 KB 214.09 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 136.01 KB 136.01 KB 36.02 KB 36.02 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 119.93 KB 119.91 KB 37.67 KB 37.67 KB NODE_PROD
react-dom-server.node.production.min.js -0.0% -0.1% 20.8 KB 20.79 KB 7.63 KB 7.62 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 134.9 KB 134.9 KB 35.78 KB 35.79 KB NODE_DEV
ReactDOM-dev.js 0.0% 0.0% 982.87 KB 982.87 KB 216.94 KB 216.94 KB FB_WWW_DEV
react-dom-server.browser.production.min.js -0.0% -0.0% 20.39 KB 20.39 KB 7.47 KB 7.47 KB NODE_PROD
ReactDOM-prod.js -0.3% -0.3% 393.42 KB 392.26 KB 71.88 KB 71.63 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.91 KB 60.91 KB 16.07 KB 16.07 KB UMD_DEV
ReactDOM-profiling.js -0.3% -0.4% 404.74 KB 403.47 KB 74.05 KB 73.76 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.23 KB 10.23 KB 3.47 KB 3.48 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.61 KB 60.61 KB 15.99 KB 16 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 9.97 KB 9.97 KB 3.37 KB 3.37 KB NODE_PROD
ReactDOMServer-dev.js 0.0% 0.0% 140.24 KB 140.24 KB 35.49 KB 35.49 KB FB_WWW_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.1% 1.21 KB 1.21 KB 697 B 698 B NODE_PROD

ReactDOM: size: -0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 813493f

@sizebot

This comment has been minimized.

Copy link

sizebot commented Jan 23, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 813493f

@trueadm

This comment has been minimized.

Copy link
Member

trueadm commented Jan 24, 2020

I'm a bit worried that upgrading GCC is now causing our production bundles to fail tests. Maybe we should find out what the cause might be and report the issue back to GCC.

@necolas necolas force-pushed the necolas:update-closure-compiler branch 2 times, most recently from d68271f to aedb6f4 Jan 24, 2020
@necolas necolas force-pushed the necolas:update-closure-compiler branch from aedb6f4 to 813493f Jan 30, 2020
@necolas

This comment has been minimized.

Copy link
Contributor Author

necolas commented Jan 31, 2020

Passing now. The previous test failures were a subset of the same tests that failed during the jest upgrade.

@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Jan 31, 2020

Thanks!

@necolas necolas merged commit 38cd758 into facebook:master Jan 31, 2020
22 checks passed
22 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.