Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concurrent Mode] Add missing event plugin priorities #17914

Merged
merged 1 commit into from Jan 28, 2020

Conversation

@trueadm
Copy link
Member

trueadm commented Jan 27, 2020

We are missing some explicit event priorties (all discrete) that are used for event plugin types. This PR adds them and their priorities so they're probably handled in Concurrent Mode. Previously, these events were missing, so their priority would default to Continious priortiy. This would be hard to observe as these events are typically used in polyfill situations where better events are either not supported well or are missing (IE etc); thus the liklihood of running into issues with Concurrent Mode would be unlikely.

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Jan 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e9e5cb8:

Sandbox Source
naughty-resonance-uhyt7 Configuration
@sizebot

This comment has been minimized.

Copy link

sizebot commented Jan 27, 2020

Details of bundled changes.

Comparing: e26682a...e9e5cb8

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js +0.1% +0.1% 123.67 KB 123.81 KB 38.76 KB 38.8 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 138.9 KB 138.9 KB 36.78 KB 36.78 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.47 KB 20.47 KB 7.5 KB 7.5 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 54.79 KB 54.79 KB 15.4 KB 15.4 KB UMD_DEV
ReactDOMServer-prod.js 0.0% -0.0% 49 KB 49 KB 11.19 KB 11.19 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 711 B 710 B UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 53.06 KB 53.06 KB 15.08 KB 15.08 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.05 KB 1.05 KB 642 B 641 B NODE_PROD
react-dom.development.js +0.1% +0.1% 958.5 KB 959.46 KB 215.3 KB 215.53 KB UMD_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 119.69 KB 119.85 KB 38.37 KB 38.42 KB UMD_PROD
react-dom.profiling.min.js +0.1% +0.1% 123.42 KB 123.58 KB 39.55 KB 39.6 KB UMD_PROFILING
react-dom.development.js +0.1% +0.1% 952.57 KB 953.52 KB 213.61 KB 213.85 KB NODE_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 119.79 KB 119.93 KB 37.63 KB 37.67 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.8 KB 20.8 KB 7.63 KB 7.63 KB NODE_PROD
react-dom-server.browser.development.js 0.0% -0.0% 134.84 KB 134.84 KB 35.76 KB 35.76 KB NODE_DEV
ReactDOM-dev.js +0.1% +0.1% 980.18 KB 981.15 KB 216.47 KB 216.71 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 393.01 KB 393.42 KB 71.79 KB 71.88 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 404.34 KB 404.75 KB 73.95 KB 74.04 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.23 KB 10.23 KB 3.48 KB 3.47 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.61 KB 60.61 KB 15.99 KB 15.99 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 9.97 KB 9.97 KB 3.37 KB 3.37 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against e9e5cb8

@sizebot

This comment has been minimized.

Copy link

sizebot commented Jan 27, 2020

Details of bundled changes.

Comparing: e26682a...e9e5cb8

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.94 KB 19.94 KB 7.4 KB 7.39 KB NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 53.05 KB 53.05 KB 15.08 KB 15.08 KB NODE_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 115.79 KB 115.95 KB 37.24 KB 37.3 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.59 KB 60.59 KB 15.99 KB 15.99 KB NODE_DEV
react-dom.profiling.min.js +0.1% +0.1% 119.41 KB 119.57 KB 38.4 KB 38.46 KB UMD_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 9.96 KB 9.96 KB 3.37 KB 3.36 KB NODE_PROD
react-dom.development.js +0.1% +0.1% 952.54 KB 953.5 KB 213.59 KB 213.83 KB NODE_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 115.86 KB 116.01 KB 36.58 KB 36.63 KB NODE_PROD
react-dom.profiling.min.js +0.1% +0.1% 119.63 KB 119.77 KB 37.7 KB 37.75 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.87 KB 3.87 KB 1.54 KB 1.54 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 703 B 702 B UMD_PROD
react-dom-server.browser.development.js 0.0% 0.0% 138.88 KB 138.88 KB 36.78 KB 36.78 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.01 KB 20.01 KB 7.41 KB 7.41 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 54.78 KB 54.78 KB 15.4 KB 15.4 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.04 KB 1.04 KB 634 B 633 B NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 10.94 KB 10.94 KB 4.08 KB 4.08 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.89 KB 60.89 KB 16.06 KB 16.06 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 689 B 688 B NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.22 KB 10.22 KB 3.47 KB 3.46 KB UMD_PROD
react-dom.development.js +0.1% +0.1% 958.48 KB 959.43 KB 215.28 KB 215.51 KB UMD_DEV

ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1%

Size changes (stable)

Generated by 🚫 dangerJS against e9e5cb8

@trueadm trueadm force-pushed the trueadm:add-priorities-for-event-types branch from 85e4de5 to 2fe49ed Jan 27, 2020
@trueadm trueadm force-pushed the trueadm:add-priorities-for-event-types branch from 2fe49ed to e9e5cb8 Jan 28, 2020
@trueadm trueadm merged commit b7f217d into facebook:master Jan 28, 2020
22 checks passed
22 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
@trueadm trueadm deleted the trueadm:add-priorities-for-event-types branch Jan 28, 2020
This was referenced Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.