Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show first component stack in context warning #17922

Merged
merged 2 commits into from Jan 29, 2020
Merged

Conversation

gaearon
Copy link
Member

@gaearon gaearon commented Jan 29, 2020

Legacy context warnings are hard to figure out when the only stack you get is to a Strict root. Especially in CM, where the Strict root is the root itself.

This is an alternative to #17882. Trying to be smart in #17882 turned out to be a bigger can of worms than I hoped. So let's just do the simplest thing and log the first callsite we encounter.

@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Jan 29, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jan 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2cdb693:

Sandbox Source
heuristic-leftpad-1g1i7 Configuration

@sizebot
Copy link

@sizebot sizebot commented Jan 29, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 2cdb693

@sizebot
Copy link

@sizebot sizebot commented Jan 29, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 2cdb693

Copy link
Contributor

@threepointone threepointone left a comment

Stamp stamp

@gaearon gaearon merged commit 57333ca into facebook:master Jan 29, 2020
22 checks passed
@gaearon gaearon deleted the ctx-wrn branch Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants