Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added $FlowFixMe to DevTools shell for module we Flow-ignore #18001

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Feb 7, 2020

Fix Flow error introduced in #17999

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 7, 2020
@sizebot
Copy link

sizebot commented Feb 7, 2020

Warnings
⚠️ Base commit is broken: d1bfdfb

Size changes (experimental)

Generated by 🚫 dangerJS against f7fad38

@sizebot
Copy link

sizebot commented Feb 7, 2020

Warnings
⚠️ Base commit is broken: d1bfdfb

Size changes (stable)

Generated by 🚫 dangerJS against f7fad38

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f7fad38:

Sandbox Source
jolly-dew-kpj28 Configuration

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no is sizebot/circleci broken again?

@bvaughn bvaughn merged commit e05dedc into facebook:master Feb 7, 2020
@bvaughn bvaughn deleted the fix-flow-devtools-shell branch February 7, 2020 22:36
@bvaughn
Copy link
Contributor Author

bvaughn commented Feb 7, 2020

Seems expected since #17999 broke master. This should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants