Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN] Add an early invariant to debug a mystery crash #18159

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 27, 2020

See D20130868 and t62461245. We've only been seeing it on RN in production, and we don't understand how this is possible. Trying to gather more details. I've turned it off in all configs except RN FB.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 27, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d50dea1:

Sandbox Source
hardcore-golick-nlsdm Configuration

@sizebot
Copy link

sizebot commented Feb 27, 2020

Details of bundled changes.

Comparing: 3e809bf...d50dea1

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-profiling.js 0.0% -0.0% 263.68 KB 263.68 KB 45.87 KB 45.87 KB RN_OSS_PROFILING
ReactFabric-dev.js +0.1% +0.1% 614.45 KB 614.82 KB 132.36 KB 132.49 KB RN_FB_DEV
ReactFabric-prod.js 🔺+0.1% 🔺+0.1% 252.87 KB 253.06 KB 43.81 KB 43.86 KB RN_FB_PROD
ReactFabric-profiling.js +0.1% +0.1% 264.02 KB 264.21 KB 45.94 KB 46 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js +0.1% +0.1% 632.53 KB 632.9 KB 136.65 KB 136.77 KB RN_FB_DEV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.1% 261.01 KB 261.2 KB 45.28 KB 45.33 KB RN_FB_PROD
ReactNativeRenderer-profiling.js +0.1% +0.1% 272.16 KB 272.35 KB 47.41 KB 47.48 KB RN_FB_PROFILING
ReactFabric-dev.js 0.0% -0.0% 611.57 KB 611.57 KB 131.98 KB 131.98 KB RN_OSS_DEV

Size changes (experimental)

Generated by 🚫 dangerJS against d50dea1

@sizebot
Copy link

sizebot commented Feb 27, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against d50dea1

@gaearon gaearon merged commit 4ee592e into facebook:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants