Modern Event System: Support nested portal/root boundaries #18201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
trueadm
force-pushed
the
modern-event-multiple-roots
branch
from
116d535
to
74c11ad
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 116d535:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fae3558:
|
trueadm
force-pushed
the
modern-event-multiple-roots
branch
5 times, most recently
from
589f059
to
3f98724
Compare
sebmarkbage
reviewed
Mar 4, 2020
trueadm
force-pushed
the
modern-event-multiple-roots
branch
from
3f98724
to
5584a7f
Compare
Disable flag Fix Fxi Fix
trueadm
force-pushed
the
modern-event-multiple-roots
branch
from
8691885
to
f4d8e96
Compare
trueadm
force-pushed
the
modern-event-multiple-roots
branch
from
f4d8e96
to
db121ba
Compare
sebmarkbage
reviewed
Mar 5, 2020
gaearon
reviewed
Mar 5, 2020
fix Fxi
trueadm
force-pushed
the
modern-event-multiple-roots
branch
from
db121ba
to
38be430
Compare
sebmarkbage
approved these changes
Mar 5, 2020
trueadm
force-pushed
the
modern-event-multiple-roots
branch
from
38be430
to
fae3558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple nested portal/root boundaries to the modern event system fork. Specifically, where you embed another React root or portal into an existing React sub-tree. Event propagation and the filtering and finding of ancestors is an important role here, and similar to the legacy event system, requires special logic to find the right ancestors to play through the plugin event system.
I've added a bunch of tests and extensive comments around the parts that get added in this PR. Note: this PR should not affect any of the existing legacy event system. I've tested this internally and all tests relating to this behavior seems to work as expected, but given it's all behind a flag that is disabled, the risk should be minimal. Also, if you turn on the flag, all our internal Jest tests pass with this code.
Left to do: