Hard-code disableModulePatternComponents in tests #18239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard-coding this until tests are fixed, to unblock master.
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
commented
Mar 6, 2020
| @@ -18,6 +18,8 @@ jest.mock('shared/ReactFeatureFlags', () => { | |||
| wwwFlags.enableUserTimingAPI = defaultFlags.enableUserTimingAPI; | |||
| wwwFlags.disableJavaScriptURLs = defaultFlags.disableJavaScriptURLs; | |||
| wwwFlags.enableDeprecatedFlareAPI = defaultFlags.enableDeprecatedFlareAPI; | |||
| wwwFlags.disableModulePatternComponents = | |||
There was a problem hiding this comment.
@gaearon To remove this, what we need to do is find all the tests that rely on module style components and wrap them in a feature flag check.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b6c6eb2:
|
|
Oops sorry. I didn't realize it wouldn't merge. |
|
That's fine! Two PRs just happened to land around the same time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard-coding this until tests are fixed, to unblock master.