Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactDOM.useEvent add flag and entry point #18267

Merged
merged 1 commit into from Mar 10, 2020

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Mar 10, 2020

This PR adds the enableUseEventAPI flag and the experimental ReactDOM.useEvent entry point (but is not exposed in any of our bundles). This PR is just very early scaffolding and doesn't do much more, follow up PRs will add more parts of the useEvent API.

Please note: This API is intended for internal FB testing only.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 10, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb321da:

Sandbox Source
blissful-roentgen-05qjc Configuration

@sizebot
Copy link

sizebot commented Mar 10, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against fb321da

@sizebot
Copy link

sizebot commented Mar 10, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against fb321da

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly uncomfortable landing this code without tests, but I assume that'll come in followup PRs.

@trueadm
Copy link
Contributor Author

trueadm commented Mar 10, 2020

@threepointone There's nothing to really test right now. The code in this PR is not used anywhere just yet. In a couple of PRs there will be something that can be tested. :)

@threepointone
Copy link
Contributor

Yeah haha I figured. :shipit:

@trueadm trueadm merged commit 2953425 into facebook:master Mar 10, 2020
@trueadm trueadm deleted the use-event-1 branch March 10, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants