Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine event system types + pass through priority #18305

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Refine event system types + pass through priority #18305

merged 1 commit into from
Mar 13, 2020

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Mar 13, 2020

This PR is mostly cosmetic, it renames some functions and allows priority to be passed through to addTrappedEventListener. I also cleaned up some of the Flow types.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 13, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 13, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0e15bae:

Sandbox Source
suspicious-mountain-hiq92 Configuration

@sizebot
Copy link

sizebot commented Mar 13, 2020 •
edited

Details of bundled changes.

Comparing: 45d26f6...0e15bae

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js 0.0% +0.1% 427.52 KB 427.62 KB 77.57 KB 77.61 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% 0.0% 12.29 KB 12.29 KB 4.52 KB 4.52 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.22 KB 58.22 KB 14.53 KB 14.53 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1013 B 1013 B 602 B 601 B NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.31 KB 10.31 KB 3.49 KB 3.48 KB UMD_PROD
ReactDOMForked-dev.js 0.0% 0.0% 980.83 KB 981.15 KB 217.97 KB 218.07 KB FB_WWW_DEV
ReactDOMForked-prod.js 0.0% 🔺+0.1% 409.87 KB 409.97 KB 74.46 KB 74.5 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.68 KB 3.68 KB 1.33 KB 1.33 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 901.78 KB 901.87 KB 198.46 KB 198.48 KB UMD_DEV
ReactDOMForked-profiling.js 0.0% +0.1% 427.52 KB 427.62 KB 77.57 KB 77.61 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 135.83 KB 135.83 KB 34.97 KB 34.97 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 118.21 KB 118.23 KB 37.98 KB 37.97 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 20.16 KB 20.16 KB 7.46 KB 7.46 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 121.92 KB 121.94 KB 39.16 KB 39.18 KB UMD_PROFILING
ReactDOMTesting-dev.js 0.0% 0.0% 917.5 KB 917.62 KB 204.69 KB 204.71 KB FB_WWW_DEV
react-dom.development.js 0.0% 0.0% 858.26 KB 858.35 KB 195.97 KB 195.98 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 390.68 KB 390.72 KB 71.14 KB 71.16 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 128.87 KB 128.87 KB 34.52 KB 34.52 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 118.29 KB 118.31 KB 37.17 KB 37.18 KB NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 59.83 KB 59.83 KB 15.85 KB 15.85 KB UMD_DEV
ReactDOMTesting-profiling.js 0.0% 0.0% 390.68 KB 390.72 KB 71.14 KB 71.16 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.07 KB 20.07 KB 7.42 KB 7.42 KB NODE_PROD
react-dom.profiling.min.js 0.0% 0.0% 122.14 KB 122.17 KB 38.36 KB 38.37 KB NODE_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 12.43 KB 12.43 KB 4.59 KB 4.59 KB UMD_PROD
ReactDOM-dev.js 0.0% 0.0% 980.83 KB 981.15 KB 217.97 KB 218.07 KB FB_WWW_DEV
ReactDOMServer-dev.js 0.0% -0.0% 139.01 KB 139.01 KB 35.48 KB 35.48 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 🔺+0.1% 409.87 KB 409.97 KB 74.46 KB 74.5 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 55.27 KB 55.27 KB 15.23 KB 15.23 KB NODE_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.71 KB 47.71 KB 11.11 KB 11.11 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 55.21 KB 55.21 KB 14.3 KB 14.3 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.04 KB 10.04 KB 3.37 KB 3.37 KB NODE_PROD
react-dom-server.node.development.js 0.0% -0.0% 130.09 KB 130.09 KB 34.77 KB 34.77 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.48 KB 20.48 KB 7.57 KB 7.57 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.1%

Size changes (stable)

Generated by 🚫 dangerJS against 0e15bae

@sizebot
Copy link

sizebot commented Mar 13, 2020 •
edited

Details of bundled changes.

Comparing: 45d26f6...0e15bae

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% 0.0% 126.54 KB 126.56 KB 39.57 KB 39.58 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.35 KB 3.35 KB 1.27 KB 1.27 KB UMD_DEV
ReactDOM-dev.js 0.0% 0.0% 934.94 KB 935.28 KB 208.08 KB 208.17 KB FB_WWW_DEV
react-dom-server.browser.development.js 0.0% -0.0% 137.42 KB 137.42 KB 35.17 KB 35.17 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.62 KB 20.62 KB 7.54 KB 7.54 KB UMD_PROD
react-dom-server.browser.development.js 0.0% -0.0% 130.38 KB 130.38 KB 34.74 KB 34.74 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.53 KB 20.53 KB 7.5 KB 7.5 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 932.27 KB 932.35 KB 203.73 KB 203.75 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 58.24 KB 58.24 KB 14.54 KB 14.54 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 122.41 KB 122.43 KB 39.13 KB 39.14 KB UMD_PROD
ReactDOMForked-dev.js 0.0% 0.0% 934.94 KB 935.28 KB 208.08 KB 208.17 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.32 KB 10.32 KB 3.5 KB 3.49 KB UMD_PROD
ReactDOMServer-dev.js 0.0% -0.0% 138.16 KB 138.16 KB 35.34 KB 35.34 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 126.24 KB 126.26 KB 40.37 KB 40.38 KB UMD_PROFILING
ReactDOMForked-prod.js 🔺+0.1% 🔺+0.1% 383.2 KB 383.55 KB 69.7 KB 69.78 KB FB_WWW_PROD
react-dom.development.js 0.0% 0.0% 887.47 KB 887.55 KB 201.22 KB 201.23 KB NODE_DEV
ReactDOMForked-profiling.js +0.1% +0.1% 400.78 KB 401.13 KB 72.73 KB 72.81 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 55.23 KB 55.23 KB 14.31 KB 14.3 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.69 KB 3.69 KB 1.34 KB 1.34 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 122.56 KB 122.58 KB 38.29 KB 38.29 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.05 KB 10.05 KB 3.38 KB 3.38 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.2% 1.16 KB 1.16 KB 662 B 661 B NODE_PROD
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 383.2 KB 383.55 KB 69.7 KB 69.78 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 400.78 KB 401.13 KB 72.73 KB 72.81 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1 KB 1 KB 610 B 609 B NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 59.84 KB 59.84 KB 15.86 KB 15.86 KB UMD_DEV
ReactDOMTesting-dev.js 0.0% 0.0% 890.85 KB 890.97 KB 199.2 KB 199.22 KB FB_WWW_DEV
ReactDOMTesting-prod.js 🔺+0.1% 🔺+0.1% 377.02 KB 377.3 KB 68.92 KB 68.98 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 55.29 KB 55.29 KB 15.24 KB 15.24 KB NODE_DEV
ReactDOMTesting-profiling.js +0.1% +0.1% 377.02 KB 377.3 KB 68.92 KB 68.98 KB FB_WWW_PROFILING
react-dom-server.node.development.js 0.0% -0.0% 131.6 KB 131.6 KB 34.99 KB 34.99 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 12.3 KB 12.3 KB 4.53 KB 4.53 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.94 KB 20.94 KB 7.65 KB 7.65 KB NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against 0e15bae

threepointone
threepointone approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank god for type systems

@trueadm trueadm merged commit 0705b72 into facebook:master Mar 13, 2020
@trueadm trueadm deleted the use-priority-if-available branch March 13, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threepointone threepointone threepointone approved these changes

@bvaughn bvaughn Awaiting requested review from bvaughn

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trueadm @sizebot @threepointone @facebook-github-bot