Replace passive effect context with boolean #18309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
bvaughn
commented
Mar 14, 2020
| @@ -299,6 +298,10 @@ let spawnedWorkDuringRender: null | Array<ExpirationTime> = null; | |||
| // receive the same expiration time. Otherwise we get tearing. | |||
| let currentEventTime: ExpirationTime = NoWork; | |||
|
|
|||
| // Dev only flag that tracks if passive effects are currently being flushed. | |||
| // We warn about state updates for unmounted components differently in this case. | |||
| let isFlushingPassiveEffects = false; | |||
There was a problem hiding this comment.
Preference on the name? (I have none.)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c2aafa7:
|
trueadm
approved these changes
Mar 16, 2020
bvaughn
deleted the
change-state-update-warning-passive-effect-destroy-2
branch
gaearon
reviewed
Mar 16, 2020
| @@ -2448,6 +2454,10 @@ function flushPassiveEffectsImpl() { | |||
| nestedPassiveUpdateCount = | |||
| rootWithPendingPassiveEffects === null ? 0 : nestedPassiveUpdateCount + 1; | |||
|
|
|||
| if (__DEV__) { | |||
| isFlushingPassiveEffects = false; | |||
There was a problem hiding this comment.
Do we have a guarantee code in between wouldn't throw even if user code throws (unless there's a bug in React)?
There was a problem hiding this comment.
User code is try/catched.
Though I wonder if I should have moved this before flushSyncCallbackQueue since that's where we reset prev exceution context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #18307