Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useEvent: Small tweaks and changes #18328

Merged
merged 1 commit into from Mar 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-dom/src/client/ReactDOMHostConfig.js
Expand Up @@ -1172,8 +1172,8 @@ export function validateEventListenerTarget(
console.warn(
'Event listener method setListener() from useEvent() hook requires the first argument to be either:' +
'\n\n' +
'1. A valid DOM node that was rendered and managed by React' +
'2. The "window" object' +
'1. A valid DOM node that was rendered and managed by React\n' +
'2. The "window" object\n' +
'3. The "document" object',
);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-dom/src/client/ReactDOMUseEvent.js
Expand Up @@ -46,7 +46,7 @@ export function useEvent(
): ReactDOMListenerMap {
const dispatcher = resolveDispatcher();
let capture = false;
let passive = false;
let passive = undefined; // Undefined means to use the browser default
let priority = getEventPriorityForListenerSystem((type: any));

if (options != null) {
Expand Down
Expand Up @@ -1318,6 +1318,55 @@ describe('DOMModernPluginEventSystem', () => {
expect(log[5]).toEqual(['bubble', buttonElement]);
});

it('handle propagation of click events mixed with onClick events', () => {
const buttonRef = React.createRef();
const divRef = React.createRef();
const log = [];
const onClick = jest.fn(e => log.push(['bubble', e.currentTarget]));
const onClickCapture = jest.fn(e =>
log.push(['capture', e.currentTarget]),
);

function Test() {
const click = ReactDOM.unstable_useEvent('click');
const clickCapture = ReactDOM.unstable_useEvent('click', {
capture: true,
});

React.useEffect(() => {
click.setListener(buttonRef.current, onClick);
clickCapture.setListener(buttonRef.current, onClickCapture);
});

return (
<button ref={buttonRef}>
<div ref={divRef} onClick={onClick} onClickCapture={onClickCapture}>
Click me!
</div>
</button>
);
}

ReactDOM.render(<Test />, container);
Scheduler.unstable_flushAll();

let buttonElement = buttonRef.current;
dispatchClickEvent(buttonElement);
expect(onClick).toHaveBeenCalledTimes(1);
expect(onClickCapture).toHaveBeenCalledTimes(1);
expect(log[0]).toEqual(['capture', buttonElement]);
expect(log[1]).toEqual(['bubble', buttonElement]);

let divElement = divRef.current;
dispatchClickEvent(divElement);
expect(onClick).toHaveBeenCalledTimes(3);
expect(onClickCapture).toHaveBeenCalledTimes(3);
expect(log[2]).toEqual(['capture', buttonElement]);
expect(log[3]).toEqual(['capture', divElement]);
expect(log[4]).toEqual(['bubble', divElement]);
expect(log[5]).toEqual(['bubble', buttonElement]);
});

it('should correctly work for a basic "click" listener on the outer target', () => {
const log = [];
const clickEvent = jest.fn(event => {
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/ReactDOMTypes.js
Expand Up @@ -78,7 +78,7 @@ export type ReactDOMResponderContext = {

export type ReactDOMListenerEvent = {|
capture: boolean,
passive: boolean,
passive: void | boolean,
priority: EventPriority,
type: string,
|};
Expand Down