Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert accidental changes to package.json #18348

Merged
merged 1 commit into from Mar 19, 2020

Conversation

@acdlite
Copy link
Member

acdlite commented Mar 19, 2020

The publish script was written before we switched to running patch releases out-of-band, so when updating the local package.json version numbers, it accidentally reverted other changes that have landed to master since 16.13 was released.

Comparison to before the automated changes. Only differences are to the changelog and the version numbers: 8311cb5...c4eda2b

The publish script was written before we switched to running patch
releases out-of-band, so when updating the local package.json version
numbers, it accidentally reverted other changes that have landed to
master since 16.13 was released.
@sizebot

This comment has been minimized.

Copy link

sizebot commented Mar 19, 2020

Warnings
⚠️ Base commit is broken: ad445b1

Size changes (experimental)

Generated by 🚫 dangerJS against c4eda2b

@acdlite

This comment has been minimized.

Copy link
Member Author

acdlite commented Mar 19, 2020

CodeSandbox CI is failing with that transient error we already know about. Not important. Merging to fix master.

@acdlite acdlite merged commit 6818a2a into facebook:master Mar 19, 2020
24 of 31 checks passed
24 of 31 checks passed
ci/codesandbox Building packages failed.
Details
ci/circleci: build_devtools_and_process_artifacts CircleCI is running your tests
Details
ci/circleci: sizebot CircleCI is running your tests
Details
ci/circleci: test_build CircleCI is running your tests
Details
ci/circleci: test_build_prod CircleCI is running your tests
Details
ci/circleci: test_devtools CircleCI is running your tests
Details
ci/circleci: test_source_prod CircleCI is running your tests
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_www Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_prod Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_variant Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_variant_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_variant_prod Your tests passed on CircleCI!
Details
ci/circleci: test_source_www_variant_prod_experimental Your tests passed on CircleCI!
Details
@sizebot

This comment has been minimized.

Copy link

sizebot commented Mar 19, 2020

Warnings
⚠️ Base commit is broken: ad445b1

Size changes (stable)

Generated by 🚫 dangerJS against c4eda2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.