Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings when the target instance is null to attemptToDispatchEvent method #18358

Closed

Conversation

suthagar23
Copy link

Summary

Add warnings when the target instance is null to attemptToDispatchEvent method. Added changes based on the existing TODO, and removed it after the fix.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 696bd93:

Sandbox Source
lucid-wiles-6lzd5 Configuration

@sizebot
Copy link

sizebot commented Mar 20, 2020

Details of bundled changes.

Comparing: dbd85a0...696bd93

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.production.min.js 0.0% 0.0% 118.39 KB 118.39 KB 37.21 KB 37.21 KB NODE_PROD
react-dom-test-utils.development.js 0.0% 0.0% 59.3 KB 59.3 KB 15.68 KB 15.68 KB UMD_DEV
ReactDOMTesting-profiling.js 0.0% 0.0% 390.97 KB 390.97 KB 71.17 KB 71.17 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% 0.0% 19.88 KB 19.88 KB 7.37 KB 7.37 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.34 KB 3.34 KB 1.26 KB 1.26 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 12.26 KB 12.26 KB 4.55 KB 4.55 KB UMD_PROD
ReactDOMForked-dev.js +0.1% 0.0% 984.33 KB 985.34 KB 218.69 KB 218.78 KB FB_WWW_DEV
ReactDOMForked-prod.js 0.0% 0.0% 410.66 KB 410.66 KB 74.58 KB 74.58 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.68 KB 3.68 KB 1.33 KB 1.33 KB NODE_DEV
react-dom.development.js +0.1% 0.0% 904.24 KB 905.05 KB 198.74 KB 198.83 KB UMD_DEV
ReactDOMForked-profiling.js 0.0% 0.0% 428.31 KB 428.31 KB 77.69 KB 77.69 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 135.15 KB 135.15 KB 34.75 KB 34.75 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.97 KB 19.97 KB 7.42 KB 7.42 KB UMD_PROD
ReactDOMTesting-dev.js +0.1% 0.0% 920.03 KB 921.03 KB 205.25 KB 205.35 KB FB_WWW_DEV
react-dom.development.js +0.1% 0.0% 860.64 KB 861.42 KB 196.27 KB 196.35 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 390.97 KB 390.97 KB 71.17 KB 71.17 KB FB_WWW_PROD
ReactDOM-dev.js +0.1% 0.0% 984.33 KB 985.34 KB 218.69 KB 218.78 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 410.66 KB 410.66 KB 74.58 KB 74.58 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% 0.0% 54.77 KB 54.77 KB 15.08 KB 15.08 KB NODE_DEV
ReactDOMServer-prod.js 0.0% 0.0% 47.41 KB 47.41 KB 11.05 KB 11.05 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 2.94 KB 2.94 KB 1.17 KB 1.17 KB NODE_DEV
ReactDOM-profiling.js 0.0% 0.0% 428.31 KB 428.31 KB 77.69 KB 77.69 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% 0.0% 12.12 KB 12.12 KB 4.47 KB 4.47 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 57.7 KB 57.7 KB 14.36 KB 14.36 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1013 B 1013 B 601 B 602 B NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.04 KB 10.04 KB 3.37 KB 3.37 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 696bd93

@sizebot
Copy link

sizebot commented Mar 20, 2020

Details of bundled changes.

Comparing: dbd85a0...696bd93

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.development.js 0.0% 0.0% 136.74 KB 136.74 KB 34.96 KB 34.96 KB UMD_DEV
react-dom.profiling.min.js 0.0% 0.0% 126.64 KB 126.64 KB 39.59 KB 39.59 KB NODE_PROFILING
ReactDOM-dev.js +0.1% 0.0% 938.51 KB 939.52 KB 208.74 KB 208.84 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 2.95 KB 2.95 KB 1.18 KB 1.18 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1 KB 1 KB 609 B 610 B NODE_PROD
react-dom-test-utils.development.js 0.0% 0.0% 59.32 KB 59.32 KB 15.69 KB 15.69 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 12.27 KB 12.27 KB 4.56 KB 4.56 KB UMD_PROD
ReactDOMTesting-dev.js +0.1% 0.0% 893.28 KB 894.28 KB 199.54 KB 199.64 KB FB_WWW_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 378.01 KB 378.01 KB 69.11 KB 69.11 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% 0.0% 54.78 KB 54.78 KB 15.08 KB 15.08 KB NODE_DEV
ReactDOMTesting-profiling.js 0.0% 0.0% 378.01 KB 378.01 KB 69.11 KB 69.11 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% 0.0% 12.13 KB 12.13 KB 4.48 KB 4.48 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.75 KB 20.75 KB 7.6 KB 7.6 KB NODE_PROD
react-dom.development.js +0.1% 0.0% 934.73 KB 935.54 KB 204.03 KB 204.12 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 122.52 KB 122.52 KB 39.15 KB 39.15 KB UMD_PROD
ReactDOMForked-dev.js +0.1% 0.0% 938.51 KB 939.52 KB 208.74 KB 208.84 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.32 KB 10.32 KB 3.49 KB 3.5 KB UMD_PROD
ReactDOMServer-dev.js 0.0% 0.0% 137.51 KB 137.51 KB 35.13 KB 35.14 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 126.35 KB 126.35 KB 40.4 KB 40.4 KB UMD_PROFILING
ReactDOMServer-prod.js 0.0% 0.0% 46.7 KB 46.7 KB 10.87 KB 10.87 KB FB_WWW_PROD
react-dom.development.js +0.1% 0.0% 889.84 KB 890.62 KB 201.5 KB 201.59 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.69 KB 3.69 KB 1.34 KB 1.34 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 122.66 KB 122.66 KB 38.32 KB 38.32 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.05 KB 10.05 KB 3.38 KB 3.38 KB NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against 696bd93

@stale
Copy link

stale bot commented Jun 20, 2020

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jun 20, 2020
@stale
Copy link

stale bot commented Jun 28, 2020

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@stale stale bot closed this Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants