ReactDOM.useEvent: fix scope propagation issue #18464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
Details of bundled changes.Comparing: 663c13d...006f23e react-dom
react-native-renderer
ReactDOM: size: 🔺+0.5%, gzip: -0.0% Size changes (stable) |
gaearon
reviewed
Apr 2, 2020
Details of bundled changes.Comparing: 663c13d...006f23e react-dom
react-native-renderer
Size changes (experimental) |
gaearon
reviewed
Apr 2, 2020
gaearon
reviewed
Apr 2, 2020
gaearon
reviewed
Apr 2, 2020
gaearon
reviewed
Apr 2, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 006f23e:
|
gaearon
reviewed
Apr 2, 2020
gaearon
reviewed
Apr 2, 2020
gaearon
reviewed
Apr 2, 2020
gaearon
reviewed
Apr 2, 2020
trueadm
force-pushed
the
fix-scope-prop
branch
3 times, most recently
from
254f61f
to
10df875
Compare
Address more feedback Address more feedback Address more feedback Fix
gaearon
reviewed
Apr 2, 2020
gaearon
reviewed
Apr 2, 2020
gaearon
approved these changes
Apr 2, 2020
Address more feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with
useEventand scopes (see attached test). Specifically, we need to pass through the instance of the scope, so we can properly track if we can stopPropagation. Previously we used thecurrentTarget, which is the last physical DOM element. In the cases of scopes, this can be problematic if we have:To get around this we instead pass around an object, as
{ instance: Fiber | null, container: EventTarget }. We use this object to maintain the instance and contain (currentTarget) separately. I also moved the logic for this into the modern event system module so we don't affect other event systems with this change.