Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bailout broken in lazy components due to default props resolving #18539

Merged
merged 3 commits into from
Apr 8, 2020

Conversation

jddxf
Copy link
Contributor

@jddxf jddxf commented Apr 8, 2020

Fix #17151

We should never compare unresolved props with resolved props. Since comparing resolved props by reference doesn't make sense, we use unresolved props in that case. Otherwise, resolved props are used.

We should never compare unresolved props with resolved props. Since comparing
resolved props by reference doesn't make sense, we use unresolved props in that
case. Otherwise, resolved props are used.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e984ff:

Sandbox Source
sad-varahamihira-eeb56 Configuration
relaxed-mountain-elspg Issue #17151

@sizebot
Copy link

sizebot commented Apr 8, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 4e984ff

@sizebot
Copy link

sizebot commented Apr 8, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 4e984ff

@gaearon gaearon merged commit 241103a into facebook:master Apr 8, 2020
@gaearon
Copy link
Collaborator

gaearon commented Apr 8, 2020

Makes sense. Thanks!

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bailing out doesn't work properly in lazy components with default props
4 participants