Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant expiration time comparisons #18620

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Remove redundant expiration time comparisons #18620

merged 1 commit into from
Apr 17, 2020

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Apr 15, 2020

I'm going through all the expiration times comparisons as part of my refactor and I noticed this one has a redundancy.

Not a huge deal but might as well backport to the current implementation.

I'll keep this PR open in case I find more.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 15, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 15, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e91c252:

Sandbox Source
optimistic-haibt-cklxr Configuration

@sizebot
Copy link

sizebot commented Apr 15, 2020 •
edited

Details of bundled changes.

Comparing: b680174...e91c252

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.production.min.js -0.0% 0.0% 119.67 KB 119.65 KB 37.54 KB 37.54 KB NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 75.12 KB 75.12 KB 20.11 KB 20.11 KB UMD_DEV
ReactDOMTesting-profiling.js -0.2% -0.1% 405.31 KB 404.46 KB 73.5 KB 73.45 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 22.82 KB 22.82 KB 8.49 KB 8.48 KB NODE_PROD
react-dom.profiling.min.js -0.0% -0.0% 123.55 KB 123.53 KB 38.67 KB 38.67 KB NODE_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 13.22 KB 13.22 KB 4.9 KB 4.89 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.19 KB 1.19 KB 699 B 698 B UMD_PROD
react-dom-server.node.development.js 0.0% -0.0% 147.14 KB 147.14 KB 38.93 KB 38.93 KB NODE_DEV
ReactDOMForked-dev.js -0.0% -0.0% 1014.87 KB 1014.67 KB 225.42 KB 225.38 KB FB_WWW_DEV
ReactDOMForked-prod.js -0.2% -0.1% 424.91 KB 424.23 KB 76.59 KB 76.54 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.16 KB 5.16 KB 1.69 KB 1.69 KB NODE_DEV
react-dom.development.js -0.0% -0.0% 907.88 KB 907.77 KB 199.4 KB 199.38 KB UMD_DEV
ReactDOMForked-profiling.js -0.2% -0.1% 435.87 KB 435.2 KB 78.49 KB 78.45 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 155.09 KB 155.09 KB 39.45 KB 39.45 KB UMD_DEV
react-dom.production.min.js -0.0% -0.0% 119.55 KB 119.53 KB 38.26 KB 38.25 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 22.92 KB 22.92 KB 8.52 KB 8.51 KB UMD_PROD
react-dom.profiling.min.js -0.0% 0.0% 123.29 KB 123.26 KB 39.51 KB 39.51 KB UMD_PROFILING
ReactDOMTesting-dev.js -0.0% -0.0% 958.92 KB 958.72 KB 213.54 KB 213.51 KB FB_WWW_DEV
react-dom.development.js -0.0% -0.0% 864.27 KB 864.15 KB 196.95 KB 196.93 KB NODE_DEV
ReactDOMTesting-prod.js -0.2% -0.1% 405.31 KB 404.46 KB 73.5 KB 73.45 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 145.92 KB 145.92 KB 38.68 KB 38.68 KB NODE_DEV
ReactDOM-dev.js -0.0% -0.0% 1014.86 KB 1014.65 KB 225.26 KB 225.23 KB FB_WWW_DEV
ReactDOM-prod.js -0.2% -0.1% 424.32 KB 423.65 KB 76.5 KB 76.46 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 69.97 KB 69.97 KB 19.6 KB 19.6 KB NODE_DEV
ReactDOMServer-prod.js 0.0% -0.0% 53.3 KB 53.3 KB 12.85 KB 12.85 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.42 KB 4.42 KB 1.54 KB 1.54 KB NODE_DEV
ReactDOM-profiling.js -0.2% -0.1% 435.29 KB 434.61 KB 78.41 KB 78.37 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 56.1 KB 56.1 KB 13.84 KB 13.84 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 53.2 KB 53.2 KB 13.65 KB 13.64 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.73 KB 9.73 KB 3.25 KB 3.25 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.0% -0.0% 655.34 KB 655.13 KB 140.75 KB 140.72 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.2% -0.1% 271.17 KB 270.59 KB 46.68 KB 46.64 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.2% -0.1% 282.6 KB 282.02 KB 48.87 KB 48.83 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.0% -0.0% 637 KB 636.8 KB 136.29 KB 136.26 KB RN_OSS_DEV
ReactFabric-prod.js -0.2% -0.1% 263.15 KB 262.57 KB 45.17 KB 45.13 KB RN_OSS_PROD
ReactFabric-profiling.js -0.2% -0.1% 274.56 KB 273.98 KB 47.35 KB 47.31 KB RN_OSS_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.0% -0.0% 634.43 KB 634.31 KB 133.73 KB 133.71 KB UMD_DEV
react-art.production.min.js -0.0% 0.0% 107.16 KB 107.14 KB 32.51 KB 32.51 KB UMD_PROD
react-art.development.js -0.0% -0.0% 538.72 KB 538.6 KB 116.16 KB 116.14 KB NODE_DEV
react-art.production.min.js -0.0% -0.0% 72.15 KB 72.13 KB 21.69 KB 21.68 KB NODE_PROD
ReactART-dev.js -0.0% -0.0% 606.4 KB 606.2 KB 127.52 KB 127.49 KB FB_WWW_DEV
ReactART-prod.js -0.3% -0.1% 251.09 KB 250.42 KB 42.67 KB 42.61 KB FB_WWW_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against e91c252

@sizebot
Copy link

sizebot commented Apr 15, 2020 •
edited

Details of bundled changes.

Comparing: b680174...e91c252

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js -0.2% -0.1% 271.18 KB 270.6 KB 46.69 KB 46.65 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.2% -0.1% 282.61 KB 282.03 KB 48.88 KB 48.84 KB RN_OSS_PROFILING
ReactFabric-prod.js -0.2% -0.1% 263.17 KB 262.59 KB 45.18 KB 45.14 KB RN_OSS_PROD
ReactFabric-profiling.js -0.2% -0.1% 274.58 KB 273.99 KB 47.36 KB 47.32 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.0% -0.0% 641.82 KB 641.62 KB 137.07 KB 137.04 KB RN_FB_DEV
ReactFabric-prod.js -0.2% -0.1% 263.32 KB 262.74 KB 45.22 KB 45.17 KB RN_FB_PROD
ReactNativeRenderer-dev.js -0.0% -0.0% 655.35 KB 655.15 KB 140.75 KB 140.73 KB RN_OSS_DEV
ReactFabric-profiling.js -0.2% -0.1% 274.72 KB 274.14 KB 47.39 KB 47.35 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js -0.0% -0.0% 660.15 KB 659.95 KB 141.55 KB 141.52 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.2% -0.1% 271.33 KB 270.75 KB 46.72 KB 46.67 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.2% -0.1% 282.75 KB 282.17 KB 48.9 KB 48.86 KB RN_FB_PROFILING
ReactFabric-dev.js -0.0% -0.0% 637.01 KB 636.81 KB 136.3 KB 136.27 KB RN_OSS_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.development.js 0.0% -0.0% 162.2 KB 162.2 KB 41.21 KB 41.21 KB UMD_DEV
react-dom.profiling.min.js -0.0% -0.0% 128.5 KB 128.47 KB 40.19 KB 40.19 KB NODE_PROFILING
ReactDOM-dev.js -0.0% -0.0% 989.59 KB 989.39 KB 220.02 KB 219.99 KB FB_WWW_DEV
ReactDOM-prod.js -0.1% -0.0% 412.91 KB 412.54 KB 74.85 KB 74.83 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.0% 423.81 KB 423.44 KB 76.72 KB 76.7 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% -0.0% 75.14 KB 75.14 KB 20.12 KB 20.12 KB UMD_DEV
ReactDOMTesting-dev.js -0.0% -0.0% 932.38 KB 932.18 KB 207.89 KB 207.86 KB FB_WWW_DEV
ReactDOMTesting-prod.js -0.2% -0.1% 393.49 KB 392.63 KB 71.7 KB 71.65 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 69.98 KB 69.98 KB 19.61 KB 19.61 KB NODE_DEV
ReactDOMTesting-profiling.js -0.2% -0.1% 393.49 KB 392.63 KB 71.7 KB 71.65 KB FB_WWW_PROFILING
react-dom-server.node.development.js 0.0% -0.0% 153.9 KB 153.9 KB 40.69 KB 40.69 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 23.69 KB 23.69 KB 8.72 KB 8.72 KB NODE_PROD
react-dom-server.browser.development.js 0.0% -0.0% 152.68 KB 152.68 KB 40.44 KB 40.44 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 23.28 KB 23.28 KB 8.57 KB 8.57 KB NODE_PROD
react-dom.development.js -0.0% -0.0% 941.57 KB 941.45 KB 205.85 KB 205.83 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 56.11 KB 56.11 KB 13.85 KB 13.85 KB UMD_DEV
react-dom.production.min.js -0.0% -0.0% 124.3 KB 124.28 KB 39.71 KB 39.7 KB UMD_PROD
ReactDOMForked-dev.js -0.0% -0.0% 989.61 KB 989.41 KB 220.17 KB 220.15 KB FB_WWW_DEV
ReactDOMServer-dev.js 0.0% -0.0% 161.46 KB 161.46 KB 40.99 KB 40.99 KB FB_WWW_DEV
react-dom.profiling.min.js -0.0% -0.0% 128.15 KB 128.13 KB 40.93 KB 40.92 KB UMD_PROFILING
ReactDOMForked-prod.js -0.1% -0.0% 413.48 KB 413.11 KB 74.93 KB 74.92 KB FB_WWW_PROD
ReactDOMServer-prod.js 0.0% -0.0% 52.57 KB 52.57 KB 12.68 KB 12.68 KB FB_WWW_PROD
react-dom.development.js -0.0% -0.0% 896.51 KB 896.4 KB 203.35 KB 203.33 KB NODE_DEV
ReactDOMForked-profiling.js -0.1% -0.0% 424.38 KB 424.01 KB 76.82 KB 76.8 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 53.21 KB 53.21 KB 13.65 KB 13.65 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.18 KB 5.18 KB 1.7 KB 1.7 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 124.5 KB 124.48 KB 38.95 KB 38.95 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 9.75 KB 9.75 KB 3.26 KB 3.25 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.0% -0.0% 658.56 KB 658.44 KB 138.52 KB 138.5 KB UMD_DEV
react-art.production.min.js -0.0% -0.0% 110.44 KB 110.42 KB 33.43 KB 33.43 KB UMD_PROD
react-art.development.js -0.0% -0.0% 561.85 KB 561.73 KB 120.99 KB 120.97 KB NODE_DEV
react-art.production.min.js -0.0% -0.0% 75.39 KB 75.36 KB 22.67 KB 22.66 KB NODE_PROD
ReactART-dev.js -0.0% -0.0% 596.33 KB 596.13 KB 125.52 KB 125.49 KB FB_WWW_DEV
ReactART-prod.js -0.1% -0.1% 243.64 KB 243.28 KB 41.43 KB 41.39 KB FB_WWW_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against e91c252

@acdlite
Remove redundant expiration time comparisons
e91c252 
I'm going through all the expiration times comparisons as part of my
refactor and I noticed this one has a redundancy.
@acdlite acdlite merged commit a4b1e65 into facebook:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acdlite @sizebot @sebmarkbage @facebook-github-bot