Remove redundant conditional statements #18627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it will continue when the props are equal in line 767, there is no need to compare whether they are not equal.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ae788c4:
|
bvaughn
reviewed
Apr 16, 2020
| @@ -824,10 +824,7 @@ export function diffProperties( | |||
| // inserted already. | |||
| } | |||
| } else if (propKey === CHILDREN) { | |||
| if ( | |||
| lastProp !== nextProp && | |||
There was a problem hiding this comment.
This change seems nice, since we already check for this above
| @@ -405,12 +405,11 @@ function ChildReconciler(shouldTrackSideEffects) { | |||
| ); | |||
| created.return = returnFiber; | |||
| return created; | |||
| } else { | |||
There was a problem hiding this comment.
This change is subjective and I think should be reverted.
| @@ -405,12 +405,11 @@ function ChildReconciler(shouldTrackSideEffects) { | |||
| ); | |||
| created.return = returnFiber; | |||
| return created; | |||
| } else { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove redundant conditional statements