Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise isFiberInsideHiddenOrRemovedTree #18662

Merged

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Apr 17, 2020

We can validate the child of the Suspense Component to see what branch the active element is in. Note: this is not a thorough fix, as it doesn't take into account the fact that the active element might be in both branches due to a lower-pri update.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 17, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f1df3cc:

Sandbox Source
affectionate-dream-18sj7 Configuration

@trueadm trueadm force-pushed the Revise-isFiberInsideHiddenOrRemovedTree branch from 359ce50 to f1df3cc Compare April 17, 2020 22:49
@sizebot
Copy link

sizebot commented Apr 17, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against f1df3cc

@sizebot
Copy link

sizebot commented Apr 17, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against f1df3cc

@trueadm trueadm merged commit e7163a9 into facebook:master Apr 17, 2020
@trueadm trueadm deleted the Revise-isFiberInsideHiddenOrRemovedTree branch April 17, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants