Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Pressable click fix" #18688

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Apr 21, 2020

Reverts #18625

When clicking on navigation items, we don't seem to be calling preventDefault, resulting in full page reloads internally.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 21, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e7bbb9d:

Sandbox Source
inspiring-moore-i0n0i Configuration

@sizebot
Copy link

sizebot commented Apr 21, 2020

Details of bundled changes.

Comparing: 80d39d8...e7bbb9d

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/keyboard.development.js 0.0% -0.0% 6.33 KB 6.33 KB 2.31 KB 2.31 KB UMD_DEV
ReactEventsPressLegacy-dev.js +10.4% +7.3% 21.47 KB 23.71 KB 5.38 KB 5.77 KB FB_WWW_DEV
react-interactions-events/deprecated-focus.development.js 0.0% -0.1% 17.25 KB 17.25 KB 3.4 KB 3.4 KB UMD_DEV
react-interactions-events/deprecated-focus.production.min.js 0.0% -0.1% 5.56 KB 5.56 KB 1.82 KB 1.82 KB UMD_PROD
react-interactions-events/deprecated-focus.development.js 0.0% -0.1% 16.15 KB 16.15 KB 3.3 KB 3.3 KB NODE_DEV
react-interactions-events/deprecated-focus.production.min.js 0.0% -0.1% 5.38 KB 5.38 KB 1.74 KB 1.74 KB NODE_PROD
react-interactions-events/context-menu.development.js 0.0% -0.1% 2.86 KB 2.86 KB 1.05 KB 1.05 KB UMD_DEV
react-interactions-events/press-legacy.development.js +8.4% +6.1% 22.82 KB 24.74 KB 5.67 KB 6.02 KB UMD_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.1% 1.42 KB 1.42 KB 756 B 755 B UMD_PROD
react-interactions-events/press-legacy.production.min.js 🔺+8.5% 🔺+5.2% 6.75 KB 7.32 KB 2.62 KB 2.76 KB UMD_PROD
react-interactions-events/context-menu.development.js 0.0% -0.2% 2.5 KB 2.5 KB 990 B 988 B NODE_DEV
react-interactions-events/press-legacy.development.js +8.7% +6.1% 21.48 KB 23.34 KB 5.55 KB 5.89 KB NODE_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.3% 1.22 KB 1.22 KB 681 B 679 B NODE_PROD
react-interactions-events/press-legacy.production.min.js 🔺+8.8% 🔺+5.9% 6.55 KB 7.12 KB 2.54 KB 2.69 KB NODE_PROD
ReactEventsPressLegacy-prod.js 🔺+11.8% 🔺+7.9% 15.12 KB 16.91 KB 3.44 KB 3.71 KB FB_WWW_PROD
react-interactions-events/keyboard.development.js 0.0% -0.1% 5.75 KB 5.75 KB 2.21 KB 2.21 KB NODE_DEV
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.27 KB 2.27 KB 1.19 KB 1.19 KB NODE_PROD
react-interactions-events/hover.production.min.js 0.0% -0.1% 3.49 KB 3.49 KB 1.24 KB 1.24 KB UMD_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 7.75 KB 7.75 KB 1.64 KB 1.64 KB NODE_DEV
react-interactions-events/hover.production.min.js 0.0% -0.1% 3.3 KB 3.3 KB 1.16 KB 1.16 KB NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against e7bbb9d

@sizebot
Copy link

sizebot commented Apr 21, 2020

Details of bundled changes.

Comparing: 80d39d8...e7bbb9d

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/deprecated-focus.development.js 0.0% -0.1% 17.24 KB 17.24 KB 3.39 KB 3.39 KB UMD_DEV
react-interactions-events/press-legacy.production.min.js 🔺+8.8% 🔺+5.9% 6.53 KB 7.11 KB 2.53 KB 2.68 KB NODE_PROD
react-interactions-events/deprecated-focus.production.min.js 0.0% -0.1% 5.54 KB 5.54 KB 1.81 KB 1.81 KB UMD_PROD
react-interactions-events/context-menu.development.js 0.0% -0.2% 2.49 KB 2.49 KB 982 B 980 B NODE_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.3% 1.2 KB 1.2 KB 672 B 670 B NODE_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 8.46 KB 8.46 KB 1.72 KB 1.72 KB UMD_DEV
react-interactions-events/hover.production.min.js 0.0% -0.2% 3.48 KB 3.48 KB 1.23 KB 1.23 KB UMD_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 7.74 KB 7.74 KB 1.63 KB 1.63 KB NODE_DEV
react-interactions-events/hover.production.min.js 0.0% -0.2% 3.28 KB 3.28 KB 1.16 KB 1.15 KB NODE_PROD
react-interactions-events/press-legacy.development.js +8.4% +6.1% 22.8 KB 24.73 KB 5.67 KB 6.01 KB UMD_DEV
react-interactions-events/press-legacy.production.min.js 🔺+8.5% 🔺+5.2% 6.73 KB 7.31 KB 2.61 KB 2.75 KB UMD_PROD
react-interactions-events/press-legacy.development.js +8.7% +6.1% 21.47 KB 23.33 KB 5.54 KB 5.88 KB NODE_DEV
ReactEventsPressLegacy-dev.js +10.4% +7.3% 21.47 KB 23.71 KB 5.38 KB 5.77 KB FB_WWW_DEV
react-interactions-events/deprecated-focus.development.js 0.0% -0.1% 16.14 KB 16.14 KB 3.29 KB 3.29 KB NODE_DEV
ReactEventsPressLegacy-prod.js 🔺+11.8% 🔺+7.9% 15.12 KB 16.91 KB 3.44 KB 3.71 KB FB_WWW_PROD
react-interactions-events/deprecated-focus.production.min.js 0.0% -0.1% 5.36 KB 5.36 KB 1.74 KB 1.73 KB NODE_PROD
react-interactions-events/keyboard.development.js 0.0% -0.0% 6.31 KB 6.31 KB 2.31 KB 2.31 KB UMD_DEV
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.45 KB 2.45 KB 1.25 KB 1.25 KB UMD_PROD
react-interactions-events/keyboard.development.js 0.0% -0.0% 5.74 KB 5.74 KB 2.21 KB 2.21 KB NODE_DEV
react-interactions-events/context-menu.development.js 0.0% -0.2% 2.84 KB 2.84 KB 1.04 KB 1.04 KB UMD_DEV
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.26 KB 2.26 KB 1.18 KB 1.18 KB NODE_PROD
react-interactions-events/context-menu.production.min.js 0.0% -0.1% 1.41 KB 1.41 KB 748 B 747 B UMD_PROD

Size changes (stable)

Generated by 🚫 dangerJS against e7bbb9d

@trueadm trueadm merged commit 7b3934b into master Apr 21, 2020
@kassens kassens deleted the revert-18625-pressable-click-fix branch November 29, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants