Disable prepareStackTrace while we're generating stacks #18708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8d56927:
|
|
@bvaughn Should we port this to DevTools too? |
gaearon
approved these changes
Apr 23, 2020
| @@ -182,6 +185,7 @@ export function describeNativeComponentFrame( | |||
| reentry = false; | |||
| if (__DEV__) { | |||
| ReactCurrentDispatcher.current = previousDispatcher; | |||
| Error.prepareStackTrace = previousPrepareStackTrace; | |||
There was a problem hiding this comment.
Did you mean to put this outside of DEV?
Yeah seems worth adding.
I'm not sure I understand this suggestion? We don't have enough info in the string (and so a custom parser wouldn't have enough info) to fully reconstruct a |
bvaughn
approved these changes
Apr 23, 2020
This could be used to do custom formatting of the stack trace in a way that isn't compatible with how we use it. So we disable it while we use it. In theory we could call this ourselves with the result of our stack. It would be a lot of extra production code though. My personal opinion is that this should always be done server side instead of on the client. We could expose a custom parser that converts it and passes it through prepareStackTrace as structured data. That way it's external and doesn't have to be built-in to React.
sebmarkbage
force-pushed
the
preparefreshstack
branch
from
c8028d6
to
8d56927
Compare
trentm
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Jun 11, 2021
The root cause was facebook/react#18708 temporarily doing `Error.prepareStackTrace = undefined` to get a stack string. This wasn't handled correctly by error-callsites (watson/error-callsites#3). Fixes: #1980
3 tasks
trentm
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Jun 14, 2021
…7+ (#2107) The root cause was facebook/react#18708 temporarily doing `Error.prepareStackTrace = undefined` to get a stack string. This wasn't handled correctly by error-callsites (watson/error-callsites#3). Fixes: #1980
dgieselaar
pushed a commit
to dgieselaar/apm-agent-nodejs
that referenced
this pull request
Sep 10, 2021
…7+ (elastic#2107) The root cause was facebook/react#18708 temporarily doing `Error.prepareStackTrace = undefined` to get a stack string. This wasn't handled correctly by error-callsites (watson/error-callsites#3). Fixes: elastic#1980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be used to do custom formatting of the stack trace in a way that isn't compatible with how we use it. So we disable it while we use it.
In theory we could call this ourselves with the result of our stack. It would be a lot of extra production code though. My personal opinion is that this should always be done server side instead of on the client. This is not infrastructure that is worth its code size.
We could expose a custom parser that converts it and passes it through prepareStackTrace as structured data. That way it's external and doesn't have to be built-in to React.