Remove flushDiscreteUpdates, discreteUpdates and syncUpdates #18710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're simplifying discrete by merging it with sync. As such
flushSync()
can be used to flush already pending discrete work.flushSync(() => ...)
replaces discreteUpdates. syncUpdates could in theory be used to enter the discrete phase in a non-discrete event but might as well useflushSync(() => ...)
then to simplify the API surface area.Currently
flushSync
errors if nested. We might need to relax that and always flush on the inner one. Let's see if we hit it.I'm going to remove
flushControlled
as well. I need to see if I can just useflushSync
for that. In Draft's case I might be able to just let the new heuristics take over and makeflushControlled
a noop.