Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable setState before mount warning in legacy mode #18851

Merged
merged 1 commit into from
May 7, 2020

Conversation

sebmarkbage
Copy link
Collaborator

We kind of "support" this pattern in legacy mode. It's only deprecated in Concurrent Mode.

We kind of "support" this pattern in legacy mode. It's only deprecated in
Concurrent Mode.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 7, 2020
@sebmarkbage sebmarkbage removed the request for review from 2timesjay May 7, 2020 03:16
@sebmarkbage sebmarkbage changed the title Disable setState before mount in legacy mode Disable setState before mount warning in legacy mode May 7, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8d2c468:

Sandbox Source
infallible-paper-brey3 Configuration

@sizebot
Copy link

sizebot commented May 7, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 8d2c468

@sizebot
Copy link

sizebot commented May 7, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 8d2c468

@sebmarkbage sebmarkbage merged commit 55f5cde into facebook:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants