Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Profiler commit filtering #18862

Merged
merged 2 commits into from
May 8, 2020
Merged

Disable Profiler commit filtering #18862

merged 2 commits into from
May 8, 2020

Commits on May 7, 2020

  1. Disable Profiler commit filtering 

    We used to filter "empty" DevTools commits, but it was error prone (see facebook#18798). A commit may appear to be empty (no actual durations) because of component filters, but filtering these empty commits causes interaction commit indices to be off by N. This not only corrupts the resulting data, but also potentially causes runtime errors.

For that matter, hiding "empty" commits might cause confusion too. A commit *did happen* even if none of the components the Profiler is showing were involved.
    Brian Vaughn committed May 7, 2020
    Configuration menu
    Copy the full SHA
    9ed51df View commit details
    Browse the repository at this point in the history

  2. Restart flaky CI

    Brian Vaughn committed May 7, 2020
    Configuration menu
    Copy the full SHA
    f749ea3 View commit details
    Browse the repository at this point in the history