Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Flare: fix PressLegacy preventDefault issue #18904

Merged
merged 1 commit into from May 13, 2020
Merged

React Flare: fix PressLegacy preventDefault issue #18904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/react-interactions/events/src/dom/PressLegacy.js
View file
Open in desktop
Expand Up @@ -586,7 +586,11 @@ const pressResponderImpl = {
!ctrlKey &&
!altKey
) {
nativeEvent.preventDefault();
// Prevent spacebar press from scrolling the window
const key = nativeEvent.key;
if (key === ' ' || key === 'Spacebar') {
nativeEvent.preventDefault();
}
state.shouldPreventClick = true;
}
} else {
Expand Down Expand Up @@ -637,7 +641,11 @@ const pressResponderImpl = {
addRootEventTypes(context, state);
} else {
// Prevent spacebar press from scrolling the window
if (isValidKeyboardEvent(nativeEvent) && nativeEvent.key === ' ') {
const key = nativeEvent.key;
if (
isValidKeyboardEvent(nativeEvent) &&
(key === ' ' || key === 'Spacebar')
) {
nativeEvent.preventDefault();
}
}
Expand Down
3 changes: 2 additions & 1 deletion packages/react-interactions/events/src/dom/__tests__/PressLegacy-test.internal.js
View file
Open in desktop
Expand Up @@ -1054,8 +1054,9 @@ describe.each(environmentTable)('Press responder', hasPointerEvents => {
ReactDOM.render(<Component />, container);

const target = createEventTarget(ref.current);
target.keydown({key: 'Enter', preventDefault});
target.keydown({key: 'Enter'});
target.keyup({key: 'Enter'});
target.click({preventDefault});
expect(preventDefault).toBeCalled();
expect(onPress).toHaveBeenCalledWith(
expect.objectContaining({defaultPrevented: true}),
Expand Down