Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to rollup build #18955

Closed

Conversation

bl00mber
Copy link
Contributor

@bl00mber bl00mber commented May 19, 2020

Replace vundefined in builds to actual version
Related #18085

How to reproduce the bug:

  1. run yarn build react/index --type=UMD
  2. open /build/node_modules/react/umd/react.production.min.js
  3. run yarn build react-debug-tools/index --type=NODE
  4. open /build/node_modules/react-debug-tools/cjs/react-debug-tools.production.min.js

@bl00mber bl00mber force-pushed the scripts/fix-version-vundefined branch 2 times, most recently from 7e58358 to 1d5fdfd Compare May 19, 2020 18:08
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f551738:

Sandbox Source
cranky-lewin-1jg2y Configuration

@bl00mber bl00mber force-pushed the scripts/fix-version-vundefined branch from 1d5fdfd to 2948d10 Compare May 19, 2020 18:26
@sizebot
Copy link

sizebot commented May 19, 2020

Warnings
⚠️ Base commit is broken: 23309eb

Size changes (experimental)

Generated by 🚫 dangerJS against f551738

@bl00mber bl00mber force-pushed the scripts/fix-version-vundefined branch from 2948d10 to f551738 Compare May 19, 2020 20:00
@sizebot
Copy link

sizebot commented May 19, 2020

Warnings
⚠️ Base commit is broken: 23309eb

Size changes (stable)

Generated by 🚫 dangerJS against f551738

@stale
Copy link

stale bot commented Aug 31, 2020

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Aug 31, 2020
@stale
Copy link

stale bot commented Sep 7, 2020

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@stale stale bot closed this Sep 7, 2020
@bl00mber
Copy link
Contributor Author

bl00mber commented Oct 9, 2020

@gaearon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants