Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event pooling in the modern system #18969

Merged
merged 1 commit into from May 21, 2020
Merged

Conversation

@trueadm
Copy link
Member

@trueadm trueadm commented May 21, 2020

This PR is a follow up to #18216, and re-applies much of the same logic and also keeps consistency with that PR's summary. After a bunch of internal discussions, we decided we want to go ahead with this change and bring it into the modern event system.

The main difference is that now we have a proper fork of the different event systems, we don't need to apply the gated logic around a bunch of places (other than the SyntheticEvent module). I also had to fork a bunch of tests that expect persistance when we run the modern event system. Once we remove the feature flags, we can tidy up a load of code relating to pooling (by removing it all).

@codesandbox
Copy link

@codesandbox codesandbox bot commented May 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 212c838:

Sandbox Source
wonderful-tu-5uno4 Configuration
@sizebot
Copy link

@sizebot sizebot commented May 21, 2020

Details of bundled changes.

Comparing: 22f7663...212c838

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-test-utils.development.js +0.5% +0.2% 75.29 KB 75.66 KB 20.19 KB 20.24 KB UMD_DEV
ReactDOMTesting-dev.js 0.0% 0.0% 931.26 KB 931.69 KB 208.12 KB 208.18 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 706 B 705 B UMD_PROD
react-dom.development.js 0.0% 0.0% 946.51 KB 946.87 KB 207.09 KB 207.15 KB UMD_DEV
react-dom-server.browser.development.js 0.0% -0.0% 143.86 KB 143.86 KB 36.72 KB 36.72 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 124.74 KB 124.74 KB 39.96 KB 39.96 KB UMD_PROD
ReactDOMForked-dev.js +0.1% 0.0% 1.01 MB 1.01 MB 231.9 KB 231.97 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 128.83 KB 128.83 KB 41.15 KB 41.15 KB UMD_PROFILING
ReactDOMForked-prod.js 0.0% 0.0% 429.68 KB 429.86 KB 77.65 KB 77.68 KB FB_WWW_PROD
react-dom.development.js 0.0% 0.0% 901.14 KB 901.49 KB 204.52 KB 204.57 KB NODE_DEV
ReactDOMForked-profiling.js 0.0% 0.0% 440.22 KB 440.4 KB 79.4 KB 79.42 KB FB_WWW_PROFILING
react-dom.profiling.min.js 0.0% -0.0% 129.18 KB 129.18 KB 40.36 KB 40.36 KB NODE_PROFILING
ReactDOM-dev.js +0.1% 0.0% 1.01 MB 1.01 MB 229.75 KB 229.82 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 432.15 KB 432.33 KB 76.61 KB 76.64 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% 0.0% 443.62 KB 443.79 KB 78.53 KB 78.55 KB FB_WWW_PROFILING
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.17 KB 1.17 KB 669 B 668 B NODE_PROD
ReactDOMTesting-prod.js 0.0% 0.0% 393.01 KB 393.04 KB 72.69 KB 72.7 KB FB_WWW_PROD
react-dom-test-utils.development.js +0.5% +0.3% 70.12 KB 70.47 KB 19.68 KB 19.74 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.87 KB 4.87 KB 1.71 KB 1.7 KB NODE_DEV
ReactTestUtils-dev.js +0.9% +0.4% 65.25 KB 65.86 KB 17.61 KB 17.68 KB FB_WWW_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-prod.js 0.0% 0.0% 263.95 KB 263.97 KB 45.48 KB 45.48 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 275.97 KB 276 KB 47.77 KB 47.78 KB RN_OSS_PROFILING
ReactNativeRenderer-prod.js 0.0% 0.0% 272.04 KB 272.07 KB 46.99 KB 47 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 284.08 KB 284.11 KB 49.29 KB 49.3 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js +0.1% 0.0% 665.87 KB 666.3 KB 143.07 KB 143.13 KB RN_FB_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 272 KB 272.02 KB 46.98 KB 46.98 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 284.04 KB 284.06 KB 49.27 KB 49.28 KB RN_FB_PROFILING
ReactFabric-dev.js +0.1% 0.0% 642.54 KB 642.96 KB 137.88 KB 137.94 KB RN_OSS_DEV
ReactFabric-dev.js +0.1% 0.0% 647.02 KB 647.45 KB 138.56 KB 138.61 KB RN_FB_DEV
ReactFabric-prod.js 0.0% 0.0% 263.91 KB 263.94 KB 45.46 KB 45.47 KB RN_FB_PROD
ReactNativeRenderer-dev.js +0.1% 0.0% 661.39 KB 661.82 KB 142.4 KB 142.45 KB RN_OSS_DEV
ReactFabric-profiling.js 0.0% 0.0% 275.93 KB 275.96 KB 47.75 KB 47.76 KB RN_FB_PROFILING

Size changes (experimental)

Generated by 🚫 dangerJS against 212c838

@sizebot
Copy link

@sizebot sizebot commented May 21, 2020

Details of bundled changes.

Comparing: 22f7663...212c838

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js +0.1% 0.0% 642.53 KB 642.95 KB 137.88 KB 137.93 KB RN_OSS_DEV
ReactNativeRenderer-dev.js +0.1% 0.0% 661.38 KB 661.81 KB 142.39 KB 142.45 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 272.03 KB 272.05 KB 46.99 KB 46.99 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 284.07 KB 284.1 KB 49.29 KB 49.29 KB RN_OSS_PROFILING
ReactFabric-prod.js 0.0% 0.0% 263.94 KB 263.96 KB 45.47 KB 45.47 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 275.96 KB 275.98 KB 47.76 KB 47.77 KB RN_OSS_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js 0.0% 0.0% 454.75 KB 454.93 KB 80.38 KB 80.4 KB FB_WWW_PROFILING
react-dom-unstable-fizz.node.production.min.js 0.0% -0.2% 1.16 KB 1.16 KB 660 B 659 B NODE_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 19.87 KB 19.87 KB 7.44 KB 7.44 KB UMD_PROD
ReactDOMForked-dev.js 0.0% 0.0% 1.04 MB 1.04 MB 237.73 KB 237.8 KB FB_WWW_DEV
ReactDOMForked-prod.js 0.0% 0.0% 440.87 KB 441.05 KB 79.53 KB 79.56 KB FB_WWW_PROD
react-dom.development.js 0.0% 0.0% 912.64 KB 913 KB 200.61 KB 200.67 KB UMD_DEV
ReactDOMForked-profiling.js 0.0% 0.0% 451.47 KB 451.65 KB 81.28 KB 81.31 KB FB_WWW_PROFILING
react-dom.profiling.min.js 0.0% 0.0% 123.94 KB 123.94 KB 39.73 KB 39.73 KB UMD_PROFILING
ReactDOMTesting-dev.js 0.0% 0.0% 957.06 KB 957.49 KB 213.81 KB 213.86 KB FB_WWW_DEV
react-dom.development.js 0.0% 0.0% 868.72 KB 869.07 KB 198.08 KB 198.14 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 404.87 KB 404.9 KB 74.6 KB 74.6 KB FB_WWW_PROD
react-dom-test-utils.development.js +0.5% +0.2% 75.28 KB 75.65 KB 20.18 KB 20.23 KB UMD_DEV
react-dom.profiling.min.js 0.0% -0.0% 124.19 KB 124.19 KB 38.84 KB 38.84 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 1.03 MB 1.03 MB 235.45 KB 235.52 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 443.22 KB 443.4 KB 78.47 KB 78.49 KB FB_WWW_PROD
react-dom-test-utils.development.js +0.5% +0.3% 70.11 KB 70.46 KB 19.68 KB 19.73 KB NODE_DEV
ReactTestUtils-dev.js +0.9% +0.4% 65.25 KB 65.86 KB 17.6 KB 17.67 KB FB_WWW_DEV
react-dom-server.browser.development.js 0.0% -0.0% 129.34 KB 129.34 KB 34.44 KB 34.44 KB NODE_DEV
ReactDOMServer-dev.js 0.0% 0.0% 147.39 KB 147.39 KB 37.46 KB 37.46 KB FB_WWW_DEV

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 212c838

@trueadm trueadm merged commit 4a3f779 into facebook:master May 21, 2020
31 checks passed
31 checks passed
ci/circleci: RELEASE_CHANNEL_stable_yarn_build Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_build Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_persistent Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www_variant Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_www Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_www_variant Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: sizebot_stable Your tests passed on CircleCI!
Details
ci/circleci: yarn_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_flow Your tests passed on CircleCI!
Details
ci/circleci: yarn_lint Your tests passed on CircleCI!
Details
ci/circleci: yarn_lint_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_test Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_prod_www Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_prod_www_variant Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_www Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_www_variant Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
@trueadm trueadm deleted the trueadm:no-event-pooling branch May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.