Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT LAND] New infra on old RN #19051

Closed
wants to merge 1 commit into from
Closed

[DO NOT LAND] New infra on old RN #19051

wants to merge 1 commit into from

Conversation

sebmarkbage
Copy link
Collaborator

This is just so I can sync an old version.

@sebmarkbage sebmarkbage marked this pull request as draft May 30, 2020 01:02
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 30, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 30, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d65a200:

Sandbox Source
focused-brook-57rm8 Configuration

@sizebot
Copy link

sizebot commented May 30, 2020 •
edited

Warnings
⚠️ Could not find build artifacts for base commit: b5c6dd2

Size changes (stable)

Generated by 🚫 dangerJS against d65a200

@sizebot
Copy link

sizebot commented May 30, 2020 •
edited

Warnings
⚠️ Could not find build artifacts for base commit: b5c6dd2

Size changes (experimental)

Generated by 🚫 dangerJS against d65a200

@sebmarkbage
Build FB specific Isomorphic Bundles (facebook#19049)
d65a200 
We need this so we can version them separately and use different
feature flags than we use for OSS RN.

I put them in a separate facebook-react-native folder which won't go
into the RN GH repo. I plan on moving the renderers there too but not yet.
@facebook-github-bot
Copy link

Hi @sebmarkbage!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@sebmarkbage sebmarkbage deleted the branch facebook:master October 20, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebmarkbage @sizebot @facebook-github-bot