Make event plugin injection statically resolvable #19234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
commented
Jul 1, 2020
| @@ -8,7 +8,7 @@ | |||
| */ | |||
|
|
|||
| import { | |||
| registrationNameModules, | |||
| registrationNames, | |||
There was a problem hiding this comment.
This used to be an object hash of name -> plugin. But the plugin object wasn't actually used. I changed it to a hash of name -> true. This lets us get rid of object "plugin" representations.
| targetContainer, | ||
| ); | ||
| } | ||
| extractEvents( |
There was a problem hiding this comment.
This calls into a function that will statically enumerate each of them.
| } | ||
| } | ||
|
|
||
| export function extractEvents( |
There was a problem hiding this comment.
This is the new static thing.
| @@ -50,16 +36,3 @@ export type DispatchQueueItem = {| | |||
| |}; | |||
|
|
|||
| export type DispatchQueue = Array<DispatchQueueItem>; | |||
|
|
|||
| export type ModernPluginModule<NativeEvent> = { | |||
There was a problem hiding this comment.
This concept sort of goes away.
| @@ -5,6 +5,8 @@ | |||
| * LICENSE file in the root directory of this source tree. | |||
| */ | |||
|
|
|||
| import type {EventTypes} from '../PluginModuleType'; | |||
There was a problem hiding this comment.
This isn't covered by Flow yet but this is preparing for your other PR.
gaearon
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 52669a8:
|
Details of bundled changes.Comparing: 67eb6ff...52669a8 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: 67eb6ff...52669a8 react-dom
Size changes (experimental) |
trueadm
reviewed
Jul 1, 2020
| @@ -114,6 +114,74 @@ import { | |||
| } from './EventListener'; | |||
| import {removeTrappedEventListener} from './DeprecatedDOMEventResponderSystem'; | |||
| import {topLevelEventsToDispatchConfig} from './DOMEventProperties'; | |||
| import * as ModernBeforeInputEventPlugin from './plugins/ModernBeforeInputEventPlugin'; | |||
trueadm
reviewed
Jul 1, 2020
| eventSystemFlags: EventSystemFlags, | ||
| targetContainer: null | EventTarget, | ||
| ) { | ||
| ModernSimpleEventPlugin.extractEvents( |
There was a problem hiding this comment.
Do these inline fully still? Nice if they do!
There was a problem hiding this comment.
Yeah, these inline fully.
trueadm
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only two parts of an event "plugin". Extracting function and a list of event types.
This turns plugins into ESM that use named exports for these.
Then it changes the "plugin registry" to resolve each of these two things statically.
This makes inlining possible. Doesn't seem like it influences the size but I think this is a step towards reducing the indirection in code. The next bastion are the configs themselves.