Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event config #19237

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Remove event config #19237

merged 1 commit into from
Jul 1, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jul 1, 2020

Removes the good old event config, replaced with direct method calls. Each plugin now exports registerEvents instead of eventTypes. Each registerEvents calls EventRegistry.register* methods.

@gaearon gaearon requested a review from trueadm July 1, 2020 23:17
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 1, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e40c8b9:

Sandbox Source
lively-sea-pexss Configuration

@sizebot
Copy link

sizebot commented Jul 1, 2020

Details of bundled changes.

Comparing: 991c3b8...e40c8b9

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.2% -0.2% 877.21 KB 875.5 KB 200.92 KB 200.56 KB NODE_DEV
ReactDOMForked-prod.js -0.4% -0.5% 401.74 KB 400 KB 74.48 KB 74.13 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% 0.0% 136.88 KB 136.88 KB 36.35 KB 36.35 KB NODE_DEV
react-dom.production.min.js -0.8% -0.6% 119.6 KB 118.59 KB 38.36 KB 38.13 KB NODE_PROD
ReactDOMForked-profiling.js -0.4% -0.5% 412.33 KB 410.6 KB 76.25 KB 75.89 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 142.96 KB 142.96 KB 36.55 KB 36.55 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.22 KB 20.22 KB 7.59 KB 7.59 KB NODE_PROD
ReactDOMTesting-dev.js -0.2% -0.1% 964.45 KB 962.65 KB 216.07 KB 215.75 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 51.13 KB 51.13 KB 14.9 KB 14.89 KB NODE_DEV
ReactDOMTesting-prod.js -0.4% -0.5% 402.68 KB 400.98 KB 75.81 KB 75.46 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 10.19 KB 10.19 KB 3.98 KB 3.98 KB NODE_PROD
react-dom.development.js -0.2% -0.2% 921.69 KB 919.85 KB 203.33 KB 202.94 KB UMD_DEV
react-dom.production.min.js -0.8% -0.6% 119.48 KB 118.51 KB 39.09 KB 38.85 KB UMD_PROD
react-dom.profiling.min.js -0.8% -0.6% 123.38 KB 122.4 KB 40.28 KB 40.03 KB UMD_PROFILING
ReactDOMForked-dev.js -0.2% -0.1% 994.12 KB 992.32 KB 221.67 KB 221.37 KB FB_WWW_DEV
react-dom.profiling.min.js -0.8% -0.6% 123.66 KB 122.66 KB 39.52 KB 39.3 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% 0.0% 19.88 KB 19.88 KB 7.44 KB 7.45 KB UMD_PROD
ReactDOM-dev.js -0.2% -0.1% 1001.23 KB 999.43 KB 222.97 KB 222.66 KB FB_WWW_DEV
ReactDOM-prod.js -0.4% -0.5% 401.93 KB 400.2 KB 74.5 KB 74.14 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% 0.0% 135.61 KB 135.61 KB 36.1 KB 36.1 KB NODE_DEV
ReactDOM-profiling.js -0.4% -0.5% 412.53 KB 410.79 KB 76.26 KB 75.91 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% 0.0% 19.8 KB 19.8 KB 7.43 KB 7.43 KB NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 55.52 KB 55.52 KB 15.36 KB 15.36 KB UMD_DEV

Size changes (stable)

Generated by 🚫 dangerJS against e40c8b9

@sizebot
Copy link

sizebot commented Jul 1, 2020

Details of bundled changes.

Comparing: 991c3b8...e40c8b9

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.2% -0.2% 907.64 KB 905.93 KB 206.46 KB 206.09 KB NODE_DEV
ReactDOMForked-prod.js -0.4% -0.5% 390.55 KB 388.82 KB 72.92 KB 72.55 KB FB_WWW_PROD
react-dom.production.min.js -0.8% -0.6% 124.06 KB 123.06 KB 39.66 KB 39.41 KB NODE_PROD
ReactDOMForked-profiling.js -0.4% -0.5% 401.09 KB 399.35 KB 74.68 KB 74.3 KB FB_WWW_PROFILING
ReactDOMTesting-dev.js -0.2% -0.2% 936.42 KB 934.63 KB 210.23 KB 209.86 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 51.15 KB 51.15 KB 14.9 KB 14.9 KB NODE_DEV
ReactDOMTesting-prod.js -0.4% -0.5% 389.17 KB 387.47 KB 73.75 KB 73.4 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.61 KB 5.61 KB 1.87 KB 1.86 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.2 KB 10.2 KB 3.99 KB 3.99 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 5.36 KB 5.36 KB 1.81 KB 1.8 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.2% 1.17 KB 1.17 KB 666 B 667 B NODE_PROD
react-dom.development.js -0.2% -0.2% 953.48 KB 951.63 KB 208.94 KB 208.53 KB UMD_DEV
react-dom.production.min.js -0.8% -0.7% 123.88 KB 122.91 KB 40.45 KB 40.19 KB UMD_PROD
react-dom.profiling.min.js -0.8% -0.6% 127.82 KB 126.85 KB 41.61 KB 41.38 KB UMD_PROFILING
ReactDOMForked-dev.js -0.2% -0.2% 968.57 KB 966.78 KB 216.57 KB 216.21 KB FB_WWW_DEV
react-dom.profiling.min.js -0.8% -0.5% 128.18 KB 127.18 KB 40.82 KB 40.62 KB NODE_PROFILING
ReactDOM-dev.js -0.2% -0.2% 975.68 KB 973.88 KB 217.87 KB 217.51 KB FB_WWW_DEV
ReactDOM-prod.js -0.4% -0.5% 390.75 KB 389.01 KB 72.93 KB 72.56 KB FB_WWW_PROD
ReactDOM-profiling.js -0.4% -0.5% 401.28 KB 399.54 KB 74.69 KB 74.32 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% -0.0% 55.53 KB 55.53 KB 15.37 KB 15.37 KB UMD_DEV

Size changes (experimental)

Generated by 🚫 dangerJS against e40c8b9

@gaearon gaearon merged commit b6df441 into facebook:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants