Fix bug with enableLegacyFBSupport click handlers #19378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6995565:
|
trueadm
force-pushed
the
fix-legacy-click-bug
branch
from
9def4b3
to
06defe6
Compare
Fix other test Prettier
trueadm
force-pushed
the
fix-legacy-click-bug
branch
from
06defe6
to
6995565
Compare
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an internal issue where
clickevent handlers would double invoke when mixed with syncclick()events in the same event cycle. Funnily enough we already had a test that caught this that at the time couldn't be fixed with the old design and the assumption made back then was clearly incorrect. Now we've redesigned the event system, we can appropiately fix this and remove the old assumption.