Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a nice React logo gif to make the readme.md file interesting. #19451

Closed
wants to merge 5 commits into from

Conversation

trupti0101
Copy link

Summary

Test Plan

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6824fdf:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jul 25, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 6824fdf

@merelinguist
Copy link

This is a little nauseating for me to look at :/. Since there‘s no way to use media queries in Markdown to test for prefers-reduced-motion as there are on the web, this would probably be better as a static image, if anything.

Copy link

@tobiasbueschel tobiasbueschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this PR and nice working getting the animation to work. I agree with @merelinguist, the spinning motion is a bit nauseating.

On the same note, I would say that the logo should be hosted in this repo instead of a third-party host.

I think it would also be good if you could align this with the other two duplicate PRs:

@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Dec 25, 2020
@stale
Copy link

stale bot commented Jan 9, 2022

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@stale stale bot closed this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants