Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated syntax and readme to match changes made at #17380 #19456

Closed
wants to merge 4 commits into from
Closed

Updated syntax and readme to match changes made at #17380 #19456

wants to merge 4 commits into from

Conversation

enahsor
Copy link

@enahsor enahsor commented Jul 26, 2020

Summary

Due to changes made at #17380, the time-slicing fixture would throw a TypeError: Object(...) is not a function whenever yarn start was ran.
The changes I made fixed this problem.
The readme for this fixture was also outdated due to the same changes.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a835f2c:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jul 26, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against a835f2c

@sizebot
Copy link

sizebot commented Jul 26, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against a835f2c

@enahsor enahsor changed the title Updated setup instructions to reflect changes made @ #17380 Updated setup instructions to reflect changes made @ #17380 and syntax in time-slicing fixture Jul 26, 2020
@enahsor enahsor changed the title Updated setup instructions to reflect changes made @ #17380 and syntax in time-slicing fixture Updated syntax and readme due to match changes made at [#17380](https://github.com/facebook/react/pull/17380) Jul 26, 2020
@enahsor enahsor changed the title Updated syntax and readme due to match changes made at [#17380](https://github.com/facebook/react/pull/17380) Updated syntax and readme due to match changes made at #17380 Jul 26, 2020
@enahsor enahsor changed the title Updated syntax and readme due to match changes made at #17380 Updated syntax and readme to match changes made at #17380 Jul 26, 2020
 the commit.

Syncing fork with upstream
@stale
Copy link

stale bot commented Jun 11, 2021

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jun 11, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@stale stale bot closed this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants