Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unprefixed animation/transition events #19493

Closed
wants to merge 1 commit into from
Closed

Use unprefixed animation/transition events #19493

wants to merge 1 commit into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jul 30, 2020

Let's drop this polyfill.

The prefixed version of transitionend only existed in old iOS, Opera, and old (pre 4.4.4) Androids.

All of those have very low market share, about 0.3% in total.

Screenshot 2020-07-30 at 16 57 17

Screenshot 2020-07-30 at 16 57 47

Screenshot 2020-07-30 at 17 13 45

Screenshot 2020-07-30 at 17 13 56

@gaearon gaearon requested a review from trueadm July 30, 2020 16:19
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 30, 2020
@gaearon
Copy link
Collaborator Author

gaearon commented Jul 30, 2020 •
edited

Looks like animation prefixing is still needed for IE 10. Bummer.
https://www.sitepoint.com/css3-animation-javascript-event-handlers/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3af9c54:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jul 30, 2020

Details of bundled changes.

Comparing: 6ef997b...3af9c54

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.3% -0.3% 924.58 KB 922.22 KB 210.21 KB 209.56 KB NODE_DEV
ReactDOMForked-prod.js -0.5% -0.7% 399.79 KB 397.86 KB 74.14 KB 73.6 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 138.87 KB 138.87 KB 36.72 KB 36.72 KB NODE_DEV
react-dom.production.min.js -0.6% -0.8% 124.27 KB 123.49 KB 39.85 KB 39.55 KB NODE_PROD
ReactDOMForked-profiling.js -0.5% -0.7% 415.29 KB 413.36 KB 76.88 KB 76.34 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 145.06 KB 145.06 KB 36.91 KB 36.91 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.72 KB 20.72 KB 7.68 KB 7.67 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 12.86 KB 12.86 KB 5.04 KB 5.04 KB UMD_PROD
ReactDOMTesting-dev.js -0.2% -0.3% 959.96 KB 957.59 KB 215.28 KB 214.68 KB FB_WWW_DEV
ReactDOMTesting-prod.js -0.5% -0.7% 403.3 KB 401.36 KB 75.94 KB 75.42 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 12.71 KB 12.71 KB 4.97 KB 4.97 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 5.36 KB 5.36 KB 1.81 KB 1.8 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 706 B 705 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.87 KB 4.87 KB 1.71 KB 1.7 KB NODE_DEV
react-dom.development.js -0.3% -0.3% 971.16 KB 968.67 KB 212.76 KB 212.12 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.01 KB 1.01 KB 617 B 616 B NODE_PROD
react-dom.production.min.js -0.6% -0.6% 124.12 KB 123.35 KB 40.58 KB 40.33 KB UMD_PROD
react-dom.profiling.min.js -0.6% -0.7% 129.3 KB 128.52 KB 42.21 KB 41.93 KB UMD_PROFILING
ReactDOMForked-dev.js -0.2% -0.3% 1002.63 KB 1000.26 KB 223.04 KB 222.45 KB FB_WWW_DEV
react-dom.profiling.min.js -0.6% -0.7% 129.65 KB 128.87 KB 41.47 KB 41.17 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.38 KB 20.38 KB 7.55 KB 7.54 KB UMD_PROD
ReactDOM-dev.js -0.2% -0.3% 994.82 KB 992.45 KB 222.08 KB 221.48 KB FB_WWW_DEV
ReactDOM-prod.js -0.5% -0.7% 395.91 KB 393.98 KB 73.52 KB 72.99 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 137.6 KB 137.6 KB 36.47 KB 36.47 KB NODE_DEV
ReactDOM-profiling.js -0.5% -0.7% 410.31 KB 408.38 KB 76.15 KB 75.63 KB FB_WWW_PROFILING
ReactDOMServer-dev.js 0.0% -0.0% 143.44 KB 143.44 KB 36.48 KB 36.48 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 65.91 KB 65.91 KB 18.18 KB 18.18 KB UMD_DEV

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 3af9c54

@sizebot
Copy link

sizebot commented Jul 30, 2020

Details of bundled changes.

Comparing: 6ef997b...3af9c54

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.3% -0.3% 887.46 KB 885.1 KB 203.39 KB 202.77 KB NODE_DEV
ReactDOMForked-prod.js -0.5% -0.6% 410.92 KB 408.99 KB 75.77 KB 75.31 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 137.36 KB 137.36 KB 36.51 KB 36.5 KB NODE_DEV
react-dom.production.min.js -0.7% -0.7% 119.47 KB 118.69 KB 38.41 KB 38.13 KB NODE_PROD
ReactDOMForked-profiling.js -0.5% -0.6% 426.48 KB 424.55 KB 78.48 KB 78.03 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 143.48 KB 143.48 KB 36.72 KB 36.71 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.26 KB 20.26 KB 7.6 KB 7.6 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 12.84 KB 12.84 KB 5.03 KB 5.03 KB UMD_PROD
ReactDOMTesting-dev.js -0.2% -0.3% 988.13 KB 985.75 KB 220.69 KB 220.12 KB FB_WWW_DEV
ReactDOMTesting-prod.js -0.5% -0.6% 415.54 KB 413.61 KB 77.77 KB 77.32 KB FB_WWW_PROD
react-dom.development.js -0.3% -0.3% 932.25 KB 929.76 KB 205.89 KB 205.24 KB UMD_DEV
react-dom.production.min.js -0.6% -0.7% 119.37 KB 118.6 KB 39.08 KB 38.83 KB UMD_PROD
react-dom.profiling.min.js -0.6% -0.7% 123.28 KB 122.51 KB 40.3 KB 40.02 KB UMD_PROFILING
ReactDOMForked-dev.js -0.2% -0.2% 1 MB 1 MB 227.75 KB 227.18 KB FB_WWW_DEV
react-dom.profiling.min.js -0.6% -0.8% 123.54 KB 122.76 KB 39.68 KB 39.38 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.92 KB 19.92 KB 7.46 KB 7.46 KB UMD_PROD
ReactDOM-dev.js -0.2% -0.3% 1020.36 KB 1017.99 KB 226.75 KB 226.17 KB FB_WWW_DEV
ReactDOM-prod.js -0.5% -0.6% 407.05 KB 405.11 KB 75.15 KB 74.69 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 136.09 KB 136.09 KB 36.26 KB 36.26 KB NODE_DEV
ReactDOM-profiling.js -0.5% -0.6% 421.51 KB 419.57 KB 77.77 KB 77.32 KB FB_WWW_PROFILING
ReactDOMServer-dev.js 0.0% -0.0% 147.47 KB 147.47 KB 37.48 KB 37.48 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.54 KB 47.54 KB 11.14 KB 11.14 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 65.9 KB 65.9 KB 18.18 KB 18.18 KB UMD_DEV

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 3af9c54

trueadm
trueadm approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame about IE10 though. Are we okay to do this now?

@gaearon
Copy link
Collaborator Author

gaearon commented Jul 30, 2020

Nah, breaking IE10 seems bad. Will have to wait for 18.

@gaearon gaearon closed this Jul 30, 2020
@thoughtspile thoughtspile mentioned this pull request Jun 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gaearon @sizebot @trueadm @facebook-github-bot