Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make undefined return value invariant a warning for memo and forwardRef #19575

Closed
wants to merge 1 commit into from
Closed

Make undefined return value invariant a warning for memo and forwardRef #19575

wants to merge 1 commit into from

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Aug 10, 2020

Opening in case we decided to make this change for v17. I don't think it's the right change though.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 10, 2020
@bvaughn bvaughn marked this pull request as draft August 10, 2020 18:46
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6c6c944:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Aug 10, 2020

Details of bundled changes.

Comparing: 2704bb5...6c6c944

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js 0.0% 0.0% 684.44 KB 684.76 KB 148.3 KB 148.33 KB RN_FB_DEV
ReactFabric-dev.js 0.0% 0.0% 665.16 KB 665.48 KB 143.66 KB 143.68 KB RN_FB_DEV
ReactNativeRenderer-dev.js 0.0% 0.0% 679.05 KB 679.37 KB 147.46 KB 147.48 KB RN_OSS_DEV
ReactFabric-prod.js -0.0% -0.0% 265.64 KB 265.59 KB 47.06 KB 47.05 KB RN_FB_PROD
ReactNativeRenderer-prod.js -0.0% -0.0% 271.84 KB 271.79 KB 48.34 KB 48.33 KB RN_OSS_PROD
ReactFabric-profiling.js -0.0% -0.0% 276.99 KB 276.94 KB 49.24 KB 49.23 KB RN_FB_PROFILING
ReactNativeRenderer-profiling.js -0.0% -0.0% 283.33 KB 283.28 KB 50.52 KB 50.51 KB RN_OSS_PROFILING
ReactNativeRenderer-prod.js -0.0% -0.0% 271.79 KB 271.75 KB 48.33 KB 48.32 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.0% -0.0% 283.29 KB 283.24 KB 50.5 KB 50.49 KB RN_FB_PROFILING
ReactFabric-dev.js 0.0% 0.0% 659.76 KB 660.08 KB 142.81 KB 142.83 KB RN_OSS_DEV
ReactFabric-prod.js -0.0% -0.0% 265.67 KB 265.62 KB 47.07 KB 47.06 KB RN_OSS_PROD
ReactFabric-profiling.js -0.0% -0.0% 277.03 KB 276.98 KB 49.26 KB 49.25 KB RN_OSS_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 876.91 KB 877.15 KB 200.81 KB 200.85 KB NODE_DEV
ReactDOMForked-prod.js -0.0% -0.0% 391.17 KB 391.12 KB 71.88 KB 71.87 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 137 KB 137 KB 36.4 KB 36.4 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 119.27 KB 119.25 KB 38.32 KB 38.31 KB NODE_PROD
ReactDOMForked-profiling.js -0.0% -0.0% 406.23 KB 406.18 KB 74.64 KB 74.63 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 143.1 KB 143.1 KB 36.61 KB 36.61 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 12.86 KB 12.86 KB 5.04 KB 5.04 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% 0.0% 949.11 KB 949.43 KB 212.66 KB 212.71 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% 0.0% 60.85 KB 60.85 KB 17.64 KB 17.64 KB NODE_DEV
ReactDOMTesting-prod.js -0.0% -0.0% 391.82 KB 391.77 KB 73.36 KB 73.35 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 12.71 KB 12.71 KB 4.96 KB 4.96 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 921.35 KB 921.6 KB 203.3 KB 203.32 KB UMD_DEV
react-dom.production.min.js -0.0% -0.0% 119.22 KB 119.19 KB 38.97 KB 38.97 KB UMD_PROD
react-dom.profiling.min.js -0.0% -0.0% 123.11 KB 123.09 KB 40.19 KB 40.19 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% 0.0% 993.26 KB 993.58 KB 220.11 KB 220.14 KB FB_WWW_DEV
react-dom.profiling.min.js -0.0% -0.0% 123.34 KB 123.32 KB 39.58 KB 39.57 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 986.36 KB 986.68 KB 219.12 KB 219.15 KB FB_WWW_DEV
ReactDOM-prod.js -0.0% -0.0% 388.2 KB 388.15 KB 71.25 KB 71.24 KB FB_WWW_PROD
ReactDOM-profiling.js -0.0% -0.0% 402.39 KB 402.34 KB 73.91 KB 73.9 KB FB_WWW_PROFILING
ReactDOMServer-dev.js 0.0% 0.0% 146.97 KB 146.97 KB 37.34 KB 37.34 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.3 KB 47.3 KB 11.04 KB 11.04 KB FB_WWW_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js -0.0% -0.0% 243.91 KB 243.86 KB 43 KB 42.99 KB FB_WWW_PROD
react-art.development.js 0.0% 0.0% 666.11 KB 666.37 KB 141.98 KB 142 KB UMD_DEV
react-art.production.min.js -0.0% -0.0% 109.66 KB 109.64 KB 33.95 KB 33.94 KB UMD_PROD
react-art.development.js 0.0% 0.0% 568.49 KB 568.74 KB 124.23 KB 124.26 KB NODE_DEV
react-art.production.min.js -0.0% -0.0% 74.62 KB 74.6 KB 23.12 KB 23.12 KB NODE_PROD
ReactART-dev.js +0.1% 0.0% 632.27 KB 632.59 KB 134.26 KB 134.3 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% 0.0% 604.6 KB 604.86 KB 127.27 KB 127.28 KB UMD_DEV
react-test-renderer.production.min.js -0.0% 0.0% 76.79 KB 76.76 KB 24.01 KB 24.01 KB UMD_PROD
react-test-renderer.development.js 0.0% 0.0% 576.02 KB 576.26 KB 125.81 KB 125.84 KB NODE_DEV
react-test-renderer.production.min.js -0.0% -0.0% 76.6 KB 76.58 KB 23.72 KB 23.71 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% 0.0% 591.34 KB 591.67 KB 126.98 KB 127 KB FB_WWW_DEV
ReactTestRenderer-dev.js +0.1% 0.0% 586 KB 586.32 KB 126.71 KB 126.73 KB RN_FB_DEV
ReactTestRenderer-prod.js -0.0% -0.0% 231.22 KB 231.17 KB 42.03 KB 42.02 KB RN_FB_PROD
ReactTestRenderer-profiling.js -0.0% -0.0% 242.61 KB 242.56 KB 44.19 KB 44.18 KB RN_FB_PROFILING

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 6c6c944

@sizebot
Copy link

sizebot commented Aug 10, 2020

Details of bundled changes.

Comparing: 2704bb5...6c6c944

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 912.84 KB 913.09 KB 207.4 KB 207.42 KB NODE_DEV
ReactDOMForked-prod.js -0.0% -0.0% 380.03 KB 379.98 KB 70.13 KB 70.12 KB FB_WWW_PROD
react-dom.production.min.js -0.0% -0.0% 123.88 KB 123.86 KB 39.68 KB 39.68 KB NODE_PROD
ReactDOMForked-profiling.js -0.0% -0.0% 395.04 KB 394.99 KB 72.9 KB 72.89 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 144.69 KB 144.69 KB 36.8 KB 36.8 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.66 KB 20.66 KB 7.65 KB 7.66 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 12.87 KB 12.87 KB 5.05 KB 5.05 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% 0.0% 921.05 KB 921.37 KB 207.15 KB 207.2 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% 0.0% 60.86 KB 60.86 KB 17.65 KB 17.65 KB NODE_DEV
ReactDOMTesting-prod.js -0.0% -0.0% 379.19 KB 379.14 KB 71.27 KB 71.26 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 12.72 KB 12.72 KB 4.97 KB 4.97 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 5.27 KB 5.27 KB 1.78 KB 1.78 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.17 KB 1.17 KB 668 B 666 B NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.2 KB 1.2 KB 707 B 705 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.78 KB 4.78 KB 1.68 KB 1.68 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 959.04 KB 959.3 KB 209.94 KB 209.97 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.01 KB 1.01 KB 617 B 616 B NODE_PROD
react-dom.production.min.js -0.0% -0.0% 123.76 KB 123.74 KB 40.4 KB 40.4 KB UMD_PROD
react-dom.profiling.min.js -0.0% 0.0% 129.02 KB 129 KB 42.04 KB 42.06 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% 0.0% 967.77 KB 968.09 KB 215.33 KB 215.37 KB FB_WWW_DEV
react-dom.profiling.min.js -0.0% -0.0% 129.33 KB 129.31 KB 41.3 KB 41.3 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 960.87 KB 961.19 KB 214.43 KB 214.47 KB FB_WWW_DEV
ReactDOM-prod.js -0.0% -0.0% 377.05 KB 377 KB 69.54 KB 69.53 KB FB_WWW_PROD
ReactDOM-profiling.js -0.0% -0.0% 391.19 KB 391.14 KB 72.21 KB 72.21 KB FB_WWW_PROFILING
ReactDOMServer-dev.js 0.0% -0.0% 142.94 KB 142.94 KB 36.34 KB 36.34 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% 0.0% 65.88 KB 65.88 KB 18.18 KB 18.18 KB UMD_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js 0.0% 0.0% 679.06 KB 679.38 KB 147.46 KB 147.49 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.0% -0.0% 271.85 KB 271.8 KB 48.35 KB 48.34 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.0% -0.0% 283.35 KB 283.3 KB 50.53 KB 50.52 KB RN_OSS_PROFILING
ReactFabric-dev.js 0.0% 0.0% 659.77 KB 660.09 KB 142.81 KB 142.83 KB RN_OSS_DEV
ReactFabric-prod.js -0.0% -0.0% 265.68 KB 265.63 KB 47.08 KB 47.07 KB RN_OSS_PROD
ReactFabric-profiling.js -0.0% -0.0% 277.04 KB 276.99 KB 49.27 KB 49.25 KB RN_OSS_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js -0.0% -0.0% 236.77 KB 236.72 KB 41.74 KB 41.72 KB FB_WWW_PROD
react-art.development.js 0.0% 0.0% 693.51 KB 693.76 KB 147.02 KB 147.06 KB UMD_DEV
react-art.production.min.js -0.0% -0.0% 112.64 KB 112.61 KB 34.88 KB 34.88 KB UMD_PROD
react-art.development.js 0.0% 0.0% 594.61 KB 594.85 KB 129.19 KB 129.22 KB NODE_DEV
react-art.production.min.js -0.0% -0.0% 77.54 KB 77.51 KB 23.99 KB 23.98 KB NODE_PROD
ReactART-dev.js +0.1% 0.0% 622.25 KB 622.57 KB 132.22 KB 132.26 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% 0.0% 604.63 KB 604.88 KB 127.28 KB 127.3 KB UMD_DEV
react-test-renderer.production.min.js -0.0% 0.0% 76.81 KB 76.79 KB 24.03 KB 24.03 KB UMD_PROD
react-test-renderer.development.js 0.0% 0.0% 576.04 KB 576.29 KB 125.83 KB 125.85 KB NODE_DEV
react-test-renderer.production.min.js -0.0% -0.0% 76.63 KB 76.6 KB 23.74 KB 23.73 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% 0.0% 591.36 KB 591.68 KB 126.99 KB 127.01 KB FB_WWW_DEV
ReactTestRenderer-dev.js +0.1% 0.0% 586.01 KB 586.33 KB 126.71 KB 126.74 KB RN_FB_DEV
ReactTestRenderer-prod.js -0.0% -0.0% 231.24 KB 231.19 KB 42.04 KB 42.03 KB RN_FB_PROD
ReactTestRenderer-profiling.js -0.0% -0.0% 242.62 KB 242.57 KB 44.2 KB 44.19 KB RN_FB_PROFILING

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 6c6c944

@bvaughn bvaughn mentioned this pull request Aug 10, 2020
Closed
@bvaughn bvaughn closed this Aug 11, 2020
@bvaughn bvaughn reopened this Aug 11, 2020
@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 11, 2020 •
edited

Re-opening for discussion and consideration.

(I still feel that the original change– the added invariant– is probably the right move though.)

@bvaughn bvaughn closed this Feb 11, 2021
@bvaughn bvaughn deleted the undefined-return-value-feature-flag branch February 11, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bvaughn @sizebot @facebook-github-bot