fix event.relatedTarget fallback logic for firefox #19607
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ccdf9c2:
|
|
Does the new check work as you expect for all browsers? |
|
yes! It will return |
gaearon
merged commit fe6d052
into
facebook:master
32 checks passed
32 checks passed
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www_variant
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Summary
Fixed a bug where if the nativeEvent
relatedTargetproperty was null in Firefox, it would return undefined.Issue: #19572
Test Plan
Tested on Firefox 79, now returns
nullif nativeEvent isnull.Tested in the following environments to make sure behavior was unaffected and no new bugs were introduced: