Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling Profiler: Add How-To, loader & some UI tweaks #19690

Closed

Conversation

kartikcho
Copy link
Contributor

@kartikcho kartikcho commented Aug 25, 2020

Summary

  • Add loading spinner when a profile is being processed (the app used to freeze the tab with no visual feedback about loading earlier).
  • Add a modal explaining the profiler's different elements, events and basic instructions.
  • Changed landing content.

This PR resolves #19676 and is a rework of MLH-Fellowship/scheduling-profiler-prototype#135 that was on hold until #19634 was merged.

I wrote some basic explanations and landing content but we should update them if they can be improved.

React Concurrent Mode Profiler - Mozilla Firefox 2020-08-25 17-50-35

cc: @bvaughn @taneliang

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a08c210:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Aug 25, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against a08c210

@sizebot
Copy link

sizebot commented Aug 25, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against a08c210

@kartikcho
Copy link
Contributor Author

Closing this PR as #19707 supersedes this. Will port the help overlay onto the new design.

@kartikcho kartikcho closed this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Broken Scheduling Profiler landing styles
3 participants