Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease expiration time of input updates #19772

Merged
merged 1 commit into from Sep 4, 2020

Commits on Sep 4, 2020

  1. Decrease expiration time of input updates

    Changes the expiration time of input updates from 1000ms to 250ms, to
    match the corresponding constant in Scheduler.js.
    
    When we made it larger, a product metric in www regressed, suggesting
    there's a user interaction that's being starved by a series of
    synchronous updates. If that theory is correct, the proper solution is
    to fix the starvation. However, this scenario supports the idea that
    expiration times are an important safeguard when starvation does happen.
    
    Also note that, in the case of user input specifically, this will soon
    no longer be an issue because we plan to make user input synchronous by
    default (until you enter `startTransition`, of course.)
    
    If weren't planning to make these updates synchronous soon anyway, I
    would probably make this number a configurable parameter.
    acdlite committed Sep 4, 2020
    Copy the full SHA
    9ec877c View commit details
    Browse the repository at this point in the history