Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate commit phase functions #19864

Merged
merged 1 commit into from
Sep 22, 2020

Commits on Sep 18, 2020

  1. Consolidate commit phase hook functions

    There were a few pairs of commit phase functions that were almost
    identical except for one detail. I've refactored them a bit to
    consolidate their implementations:
    
    - Lifted error handling logic when mounting a fiber's passive hook
    effects to surround the entire list, instead of surrounding each effect.
    - Lifted profiler duration tracking to surround the entire list.
    
    In both cases, this matches the corresponding code for the layout phase.
    
    The naming is still a bit of a mess but I'm not too concerned because
    my next step is to refactor each commit sub-phase (layout, mutation)
    so that we can store values on the JS stack. So the existing function
    boundaries are about to change, anyway.
    acdlite committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    e79b528 View commit details
    Browse the repository at this point in the history