Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade source-map-support for stack "fix" #20026

Merged
merged 2 commits into from Oct 14, 2020

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Oct 14, 2020

Summary

@gaearon for jestjs/jest#10633. While of course not the correct solution, it might unblock you

Test Plan

CI

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4415dd9:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Oct 14, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 4415dd9

@sizebot
Copy link

sizebot commented Oct 14, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 4415dd9

@gaearon gaearon merged commit 020d3aa into facebook:master Oct 14, 2020
@gaearon
Copy link
Collaborator

gaearon commented Oct 14, 2020

Thanks! FWIW this is not blocking us but is more concerning for folks in the open source who would start getting bad warnings with 17.

@SimenB SimenB deleted the sourcemap-fix branch October 14, 2020 19:52
@SimenB
Copy link
Contributor Author

SimenB commented Oct 14, 2020

Yeah, need to figure it out...

koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
* chore: downgrade source-map-support for stack "fix"

* lint?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants