Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent inlining into recursive commit functions #20105

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Prevent inlining into recursive commit functions #20105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/react-reconciler/src/ReactFiberCommitWork.new.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ function safelyCallComponentWillUnmount(
}
}

/** @noinline */
function safelyDetachRef(current: Fiber, nearestMountedAncestor: Fiber) {
const ref = current.ref;
if (ref !== null) {
Expand Down Expand Up @@ -279,6 +280,7 @@ export function safelyCallDestroy(
}
}

/** @noinline */
function commitHookEffectListUnmount(
flags: HookFlags,
finishedWork: Fiber,
Expand All @@ -303,6 +305,7 @@ function commitHookEffectListUnmount(
}
}

/** @noinline */
function commitHookEffectListMount(flags: HookFlags, finishedWork: Fiber) {
const updateQueue: FunctionComponentUpdateQueue | null = (finishedWork.updateQueue: any);
const lastEffect = updateQueue !== null ? updateQueue.lastEffect : null;
Expand Down Expand Up @@ -512,6 +515,7 @@ function iterativelyCommitBeforeMutationEffects_complete() {
}
}

/** @noinline */
function commitBeforeMutationEffectsOnFiber(finishedWork: Fiber) {
const current = finishedWork.alternate;
const flags = finishedWork.flags;
Expand Down Expand Up @@ -627,6 +631,7 @@ function commitBeforeMutationEffectsOnFiber(finishedWork: Fiber) {
}
}

/** @noinline */
function commitBeforeMutationEffectsDeletions(deletions: Array<Fiber>) {
for (let i = 0; i < deletions.length; i++) {
const fiber = deletions[i];
Expand Down Expand Up @@ -778,6 +783,7 @@ function iterativelyCommitMutationEffects_complete(
}
}

/** @noinline */
function commitMutationEffectsOnFiber(
fiber: Fiber,
root: FiberRoot,
Expand Down Expand Up @@ -848,6 +854,7 @@ function commitMutationEffectsOnFiber(
}
}

/** @noinline */
function commitMutationEffectsDeletions(
deletions: Array<Fiber>,
nearestMountedAncestor: Fiber,
Expand Down Expand Up @@ -1342,6 +1349,7 @@ function commitLayoutEffectsOnFiber(
}
}

/** @noinline */
function commitLayoutEffectsForProfiler(
finishedWork: Fiber,
finishedRoot: FiberRoot,
Expand Down Expand Up @@ -1407,6 +1415,7 @@ function commitLayoutEffectsForProfiler(
}
}

/** @noinline */
function commitLayoutEffectsForClassComponent(finishedWork: Fiber) {
const instance = finishedWork.stateNode;
const current = finishedWork.alternate;
Expand Down Expand Up @@ -1555,6 +1564,7 @@ function commitLayoutEffectsForClassComponent(finishedWork: Fiber) {
}
}

/** @noinline */
function commitLayoutEffectsForHostRoot(finishedWork: Fiber) {
// TODO: I think this is now always non-null by the time it reaches the
// commit phase. Consider removing the type check.
Expand All @@ -1575,6 +1585,7 @@ function commitLayoutEffectsForHostRoot(finishedWork: Fiber) {
}
}

/** @noinline */
function commitLayoutEffectsForHostComponent(finishedWork: Fiber) {
const instance: Instance = finishedWork.stateNode;
const current = finishedWork.alternate;
Expand All @@ -1590,6 +1601,7 @@ function commitLayoutEffectsForHostComponent(finishedWork: Fiber) {
}
}

/** @noinline */
function hideOrUnhideAllChildren(finishedWork, isHidden) {
if (supportsMutation) {
// We only have the top Fiber that was inserted but we need to recurse down its
Expand Down Expand Up @@ -2950,6 +2962,7 @@ function commitSuspenseComponent(finishedWork: Fiber) {
}
}

/** @noinline */
function commitSuspenseHydrationCallbacks(
finishedRoot: FiberRoot,
finishedWork: Fiber,
Expand Down