Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbg] resolves adding in proper warning for debugging size prop #20192

Closed
wants to merge 3 commits into from
Closed

[dbg] resolves adding in proper warning for debugging size prop #20192

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 7, 2020

Summary

Resolves adding in a more intuitive warning for the size attribute on components that are not the input or select tag.

#20159

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c89f4a3:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Nov 8, 2020

Details of bundled changes.

Comparing: 6b28eb6...c89f4a3

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% +0.1% 903.53 KB 904.08 KB 205.6 KB 205.71 KB NODE_DEV
ReactDOMForked-prod.js 0.0% 0.0% 371.02 KB 371.08 KB 69.09 KB 69.11 KB FB_WWW_PROD
react-dom-server.node.development.js +0.4% +0.3% 138.23 KB 138.77 KB 36.52 KB 36.64 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 121.51 KB 121.54 KB 39.11 KB 39.13 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% 0.0% 387.41 KB 387.47 KB 71.8 KB 71.83 KB FB_WWW_PROFILING
react-dom-server.browser.development.js +0.4% +0.3% 144.37 KB 144.94 KB 36.71 KB 36.84 KB UMD_DEV
react-dom-server.node.production.min.js 🔺+0.2% 🔺+0.2% 20.6 KB 20.64 KB 7.63 KB 7.65 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 13.71 KB 13.71 KB 5.32 KB 5.32 KB UMD_PROD
ReactDOMTesting-dev.js +0.1% +0.1% 907.9 KB 908.5 KB 204.51 KB 204.64 KB FB_WWW_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 368.41 KB 368.46 KB 69.77 KB 69.79 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 5.35 KB 5.35 KB 1.8 KB 1.8 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 5.07 KB 5.07 KB 1.74 KB 1.74 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.22 KB 1.22 KB 712 B 713 B UMD_PROD
react-dom.development.js +0.1% +0.1% 949.46 KB 950.03 KB 208.15 KB 208.27 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 121.34 KB 121.38 KB 39.85 KB 39.87 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 126.6 KB 126.63 KB 41.46 KB 41.47 KB UMD_PROFILING
ReactDOMForked-dev.js +0.1% +0.1% 965.51 KB 966.1 KB 214.36 KB 214.48 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 126.95 KB 126.99 KB 40.77 KB 40.78 KB NODE_PROFILING
react-dom-server.browser.production.min.js 🔺+0.2% 🔺+0.1% 20.28 KB 20.31 KB 7.53 KB 7.54 KB UMD_PROD
ReactDOM-dev.js +0.1% +0.1% 950.31 KB 950.91 KB 212.57 KB 212.69 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 366.94 KB 367 KB 68.16 KB 68.18 KB FB_WWW_PROD
react-dom-server.browser.development.js +0.4% +0.3% 136.96 KB 137.5 KB 36.27 KB 36.39 KB NODE_DEV
ReactDOM-profiling.js 0.0% 0.0% 380.57 KB 380.63 KB 70.64 KB 70.66 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 🔺+0.2% 🔺+0.2% 20.18 KB 20.21 KB 7.48 KB 7.49 KB NODE_PROD
ReactDOMServer-dev.js +0.4% +0.4% 141.14 KB 141.74 KB 36.22 KB 36.35 KB FB_WWW_DEV
ReactDOMServer-prod.js 🔺+0.1% 🔺+0.2% 46.28 KB 46.34 KB 10.79 KB 10.81 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% 0.0% 71.29 KB 71.29 KB 19.31 KB 19.31 KB UMD_DEV

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against c89f4a3

@sizebot
Copy link

sizebot commented Nov 8, 2020

Details of bundled changes.

Comparing: 6b28eb6...c89f4a3

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% +0.1% 871.79 KB 872.34 KB 199.59 KB 199.71 KB NODE_DEV
ReactDOMForked-prod.js 0.0% 0.0% 382.34 KB 382.4 KB 70.86 KB 70.87 KB FB_WWW_PROD
react-dom-server.node.development.js +0.4% +0.3% 136.72 KB 137.26 KB 36.31 KB 36.43 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 117.59 KB 117.63 KB 37.9 KB 37.91 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% 0.0% 398.78 KB 398.84 KB 73.58 KB 73.59 KB FB_WWW_PROFILING
react-dom-server.browser.development.js +0.4% +0.3% 142.78 KB 143.35 KB 36.51 KB 36.64 KB UMD_DEV
react-dom-server.node.production.min.js 🔺+0.2% 🔺+0.2% 20.14 KB 20.18 KB 7.56 KB 7.57 KB NODE_PROD
ReactDOMTesting-dev.js +0.1% +0.1% 936.24 KB 936.84 KB 210.02 KB 210.15 KB FB_WWW_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 381.48 KB 381.53 KB 71.99 KB 72 KB FB_WWW_PROD
react-dom.development.js +0.1% +0.1% 916.16 KB 916.73 KB 202.11 KB 202.23 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 117.49 KB 117.52 KB 38.63 KB 38.64 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 121.39 KB 121.43 KB 39.81 KB 39.83 KB UMD_PROFILING
ReactDOMForked-dev.js +0.1% +0.1% 991.09 KB 991.69 KB 219.15 KB 219.27 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 121.67 KB 121.71 KB 39.09 KB 39.11 KB NODE_PROFILING
react-dom-server.browser.production.min.js 🔺+0.2% 🔺+0.1% 19.82 KB 19.85 KB 7.44 KB 7.45 KB UMD_PROD
ReactDOM-dev.js +0.1% +0.1% 975.89 KB 976.49 KB 217.27 KB 217.4 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 378.19 KB 378.25 KB 69.93 KB 69.95 KB FB_WWW_PROD
react-dom-server.browser.development.js +0.4% +0.3% 135.45 KB 135.99 KB 36.06 KB 36.18 KB NODE_DEV
ReactDOM-profiling.js 0.0% 0.0% 391.87 KB 391.93 KB 72.4 KB 72.42 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 🔺+0.2% 🔺+0.2% 19.72 KB 19.75 KB 7.4 KB 7.42 KB NODE_PROD
ReactDOMServer-dev.js +0.4% +0.3% 145.17 KB 145.77 KB 37.23 KB 37.36 KB FB_WWW_DEV
ReactDOMServer-prod.js 🔺+0.1% 🔺+0.2% 47.15 KB 47.2 KB 11 KB 11.02 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% 0.0% 71.28 KB 71.28 KB 19.3 KB 19.3 KB UMD_DEV

Size changes (stable)

Generated by 🚫 dangerJS against c89f4a3

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 9, 2022
@sebmarkbage sebmarkbage deleted the branch facebook:master October 20, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants