Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved dev experience when DevTools hook is disabled #20208

Merged
merged 11 commits into from
Nov 11, 2020
Merged

Improved dev experience when DevTools hook is disabled #20208

Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cbd376c
Improved dev experience when DevTools hook is disabled
AceTheCreator Nov 6, 2020
fb7136d
Improved dev experience when DevTools hook is disabled
AceTheCreator Nov 6, 2020
237286f
Improved dev experience when DevTools hook is disabled
AceTheCreator Nov 6, 2020
46b6692
Improved dev experience when DevTools hook is disabled
AceTheCreator Nov 6, 2020
9cdc308
Improved dev experience when DevTools hook is disabled
AceTheCreator Nov 6, 2020
1d833fa
Improved dev experience when DevTools hook is disabled
AceTheCreator Nov 6, 2020
6115e23
Improved dev experience when DevTools hook is disabled
AceTheCreator Nov 9, 2020
700ca1c
Improved dev experience when DevTools hook is disabled
AceTheCreator Nov 9, 2020
a581a3b
Update packages/react-refresh/src/ReactFreshRuntime.js
AceTheCreator Nov 10, 2020
4937155
Actually disable Fast Refresh
bvaughn Nov 11, 2020
8527d9d
Correct name of global hook variable.
bvaughn Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-refresh/src/ReactFreshRuntime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,13 @@ export function injectIntoGlobalHook(globalObject: any): void {
onCommitFiberUnmount() {},
};
}

// Checks if DevTools hook is disabled
if (hook.isDisabled) {
console['warn'](
'Something has shimmed the React DevTools global hook (REACT_DEVTOOLS_GLOBAL_HOOK).' +
'Fast Refresh is not compatible with this shim and will be disabled. ',
);
AceTheCreator marked this conversation as resolved.
Show resolved Hide resolved
}
// Here, we just want to get a reference to scheduleRefresh.
const oldInject = hook.inject;
hook.inject = function(injected) {
Expand Down